test (8d15bc24) · Commits · jan.koester / libnetplus

debian/changelog

+6 −0

Original line number	Diff line number	Diff line
		libnetplus (20260404+6) unstable; urgency=medium

		* Remove verbose [QUIC-client] debug logging from quic.cpp

		-- Jan Koester <jan.koester@tuxist.de> Fri, 04 Apr 2026 20:30:00 +0200

		libnetplus (20260403+5) unstable; urgency=medium

		* Handshake timeout tuning

src/quic.cpp

+0 −36

Original line number	Diff line number	Diff line
		@@ -1641,15 +1641,9 @@ void quic::processInitialPacket(const uint8_t* data, size_t len) {
		// Initial packets always use AES-128 - use actual packet_len, not full datagram len
		if (!unprotectPacket(data, packet_len, header, payload, pn, key, iv, hp, true)) {
		QUIC_DBG("processInitialPacket: decrypt FAILED");
		if (!_is_server) {
		std::cerr << "[QUIC-client] Initial decrypt FAILED len=" << packet_len << std::endl;
		}
		return;
		}
		QUIC_DBG("processInitialPacket: decrypt OK pn=%lu payload=%zu", (unsigned long)pn, payload.size());
		if (!_is_server) {
		std::cerr << "[QUIC-client] Initial decrypt OK pn=" << pn << " payload=" << payload.size() << std::endl;
		}

		// Update largest received packet number
		if (pn > _initial_pn_recv) {
		@@ -1712,16 +1706,9 @@ void quic::processHandshakePacket(const uint8_t* data, size_t len) {
		// Handshake packets use the negotiated cipher - use actual packet_len
		if (!unprotectPacket(data, packet_len, header, payload, pn, key, iv, hp, false)) {
		QUIC_DBG("processHandshakePacket: decrypt FAILED");
		if (!_is_server) {
		std::cerr << "[QUIC-client] Handshake decrypt FAILED len=" << packet_len
		<< " cipher=0x" << std::hex << _selected_cipher << std::dec << std::endl;
		}
		return;
		}
		QUIC_DBG("processHandshakePacket: decrypt OK pn=%lu payload=%zu", (unsigned long)pn, payload.size());
		if (!_is_server) {
		std::cerr << "[QUIC-client] Handshake decrypt OK pn=" << pn << " payload=" << payload.size() << std::endl;
		}


		if (pn > _handshake_pn_recv) {
		@@ -2398,13 +2385,7 @@ void quic::completeHandshake() {
		if (recv_len > 0) {
		recv_got++;
		const uint8_t* pkt = reinterpret_cast<const uint8_t*>(recv_buf_wrapper.data.buf);
		std::cerr << "[QUIC-client] recv " << recv_len << " bytes (attempt " << recv_attempts
		<< ") first_byte=0x" << std::hex << (int)pkt[0] << std::dec
		<< " conn_state=" << (int)_conn_state.load()
		<< " hs_complete=" << _handshake_complete << std::endl;
		processIncomingPacket(pkt, recv_len);
		std::cerr << "[QUIC-client] after process: conn_state=" << (int)_conn_state.load()
		<< " hs_complete=" << _handshake_complete << std::endl;
		}
		} catch (NetException& e) {
		if (e.getErrorType() != NetException::Note) {
		@@ -2417,8 +2398,6 @@ void quic::completeHandshake() {
		}

		if (std::chrono::steady_clock::now() - start > timeout) {
		std::cerr << "[QUIC-client] handshake timeout: " << recv_attempts << " attempts, "
		<< recv_got << " packets received, fd=" << _Socket << std::endl;
		NetException e;
		e[NetException::Error] << "quic::completeHandshake: handshake timed out";
		throw e;
		@@ -3890,42 +3869,27 @@ void quic::processTLSMessages() {

		switch (msg_type) {
		case 0x02: // ServerHello
		if (!_is_server) {
		std::cerr << "[QUIC-client] TLS ServerHello received, len=" << msg.size() << std::endl;
		}
		// Add to transcript (client receiving from server)
		_tls_transcript.insert(_tls_transcript.end(), msg.begin(), msg.end());
		processServerHello(msg);
		break;
		case 0x08: // EncryptedExtensions
		if (!_is_server) {
		std::cerr << "[QUIC-client] TLS EncryptedExtensions received" << std::endl;
		}
		// Add to transcript (client receiving from server)
		_tls_transcript.insert(_tls_transcript.end(), msg.begin(), msg.end());
		// Parse transport parameters (flow control limits, etc.)
		processEncryptedExtensions(msg);
		break;
		case 0x0b: // Certificate
		if (!_is_server) {
		std::cerr << "[QUIC-client] TLS Certificate received" << std::endl;
		}
		// Add to transcript (client receiving from server)
		_tls_transcript.insert(_tls_transcript.end(), msg.begin(), msg.end());
		// Verify server certificate (simplified)
		break;
		case 0x0f: // CertificateVerify
		if (!_is_server) {
		std::cerr << "[QUIC-client] TLS CertificateVerify received" << std::endl;
		}
		// Add to transcript (client receiving from server)
		_tls_transcript.insert(_tls_transcript.end(), msg.begin(), msg.end());
		// Verify signature (simplified)
		break;
		case 0x14: // Finished
		if (!_is_server) {
		std::cerr << "[QUIC-client] TLS Finished received" << std::endl;
		}
		processFinished(msg);
		// Clear transcript after Finished is processed
		// Transcript is no longer needed after handshake completion