Commit 04922622 authored by Florian Tobias Schandinat's avatar Florian Tobias Schandinat
Browse files

viafb: remove 640x480-60 CRT special case 



The timing for 640x480-60 was handled different than all others.
This patch changes this by changing the blanking start and end.
The reason for this is that I can't find any reason for the old
behaviour and it was not consistent anyway as the special case for
LCD did not always trigger as the LCD code does not use this
function and it did trigger regardless of whether the display set is
CRT or LCD but only based whether any DVI/LCD device exists.
There are no negative effects observed for CRT or DVI devices.

Signed-off-by: default avatarFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
parent 92746c3c

drivers/video/via/hw.c

+0 −14
Original line number Diff line number Diff line
@@ -1488,20 +1488,6 @@ void viafb_fill_crtc_timing(struct VideoModeTable *video_mode, int bpp_byte, 
	}



	crt_reg = crt_table[index].crtc;



	/* Mode 640x480 has border, but LCD/DFP didn't have border. */

	/* So we would delete border. */

	if ((viafb_LCD_ON | viafb_DVI_ON)

	    && video_mode->crtc[0].crtc.hor_addr == 640

	    && video_mode->crtc[0].crtc.ver_addr == 480

	    && refresh == 60) {

		/* The border is 8 pixels. */

		crt_reg.hor_blank_start = crt_reg.hor_blank_start - 8;



		/* Blanking time should add left and right borders. */

		crt_reg.hor_blank_end = crt_reg.hor_blank_end + 16;

	}



	crt_reg.hor_blank_end += crt_reg.hor_blank_start;

	crt_reg.hor_sync_end += crt_reg.hor_sync_start;

	crt_reg.ver_blank_end += crt_reg.ver_blank_start;

drivers/video/via/viamode.c

+1 −1
Original line number Diff line number Diff line
@@ -281,7 +281,7 @@ static struct crt_mode_table CRTM640x480[] = { 
	/*r_rate,hsp,vsp */

	/*HT,  HA,  HBS, HBE, HSS, HSE, VT,  VA,  VBS, VBE, VSS, VSE */

	{REFRESH_60, M640X480_R60_HSP, M640X480_R60_VSP,

	 {800, 640, 648, 144, 656, 96, 525, 480, 480, 45, 490, 2} },

	 {800, 640, 640, 160, 656, 96, 525, 480, 480, 45, 490, 2} },

	{REFRESH_75, M640X480_R75_HSP, M640X480_R75_VSP,

	 {840, 640, 640, 200, 656, 64, 500, 480, 480, 20, 481, 3} },

	{REFRESH_85, M640X480_R85_HSP, M640X480_R85_VSP,