Commit 35410f86 authored by David Disseldorp's avatar David Disseldorp Committed by Martin K. Petersen
Browse files

scsi: target: sbp: Drop incorrect ASC/ASCQ usage 

The se_cmd scsi_asc and scsi_ascq members are only used for tracking ALUA
SCSI sense detail between target_core_alua and translate_sense_reason(), so
they're effectively always zero here.

Link: https://lore.kernel.org/r/20210728115353.2396-3-ddiss@suse.de


Cc: Chris Boot <bootc@bootc.net>
Reviewed-by: default avatarMike Christie <michael.christie@oracle.com>
Signed-off-by: default avatarDavid Disseldorp <ddiss@suse.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 7e457e5e

drivers/target/sbp/sbp_target.c

+2 −2
Original line number Diff line number Diff line
@@ -1389,8 +1389,8 @@ static void sbp_sense_mangle(struct sbp_target_request *req) 
		(sense[0] & 0x80) |		/* valid */

		((sense[2] & 0xe0) >> 1) |	/* mark, eom, ili */

		(sense[2] & 0x0f);		/* sense_key */

	status[2] = se_cmd->scsi_asc;		/* sense_code */

	status[3] = se_cmd->scsi_ascq;		/* sense_qualifier */

	status[2] = 0;				/* XXX sense_code */

	status[3] = 0;				/* XXX sense_qualifier */



	/* information */

	status[4] = sense[3];