Commit 002be811 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Lee Jones
Browse files

mfd: core: Add missing of_node_put for loop iteration 



Early exits from for_each_child_of_node() should decrement the
node reference counter.  Reported by Coccinelle:

  drivers/mfd/mfd-core.c:197:2-24: WARNING:
    Function "for_each_child_of_node" should have of_node_put() before goto around lines 209.

Fixes: c94bb233 ("mfd: Make MFD core code Device Tree and IRQ domain aware")
Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20210528115126.18370-1-krzysztof.kozlowski@canonical.com
parent ddb1ada4

drivers/mfd/mfd-core.c

+2 −0
Original line number Diff line number Diff line
@@ -198,6 +198,7 @@ static int mfd_add_device(struct device *parent, int id, 
			if (of_device_is_compatible(np, cell->of_compatible)) {

				/* Ignore 'disabled' devices error free */

				if (!of_device_is_available(np)) {

					of_node_put(np);

					ret = 0;

					goto fail_alias;

				}
@@ -205,6 +206,7 @@ static int mfd_add_device(struct device *parent, int id, 
				ret = mfd_match_of_node_to_dev(pdev, np, cell);

				if (ret == -EAGAIN)

					continue;

				of_node_put(np);

				if (ret)

					goto fail_alias;