Commit 0143f59d authored by Chanwoo Choi's avatar Chanwoo Choi Committed by Kishon Vijay Abraham I
Browse files

extcon: Remove the state_store() to prevent the wrong access 



This patch removes the state_store() which change the state of external
connectors with bit masking on user-space. It is wrong access to modify
the change the state of external connectors.

Signed-off-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
parent 1662622f

drivers/extcon/extcon.c

+1 −20
Original line number Diff line number Diff line
@@ -174,26 +174,7 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr, 


	return count;

}



static ssize_t state_store(struct device *dev, struct device_attribute *attr,

			   const char *buf, size_t count)

{

	u32 state;

	ssize_t ret = 0;

	struct extcon_dev *edev = dev_get_drvdata(dev);



	ret = sscanf(buf, "0x%x", &state);

	if (ret == 0)

		ret = -EINVAL;

	else

		ret = extcon_set_state(edev, state);



	if (ret < 0)

		return ret;



	return count;

}

static DEVICE_ATTR_RW(state);

static DEVICE_ATTR_RO(state);



static ssize_t name_show(struct device *dev, struct device_attribute *attr,

		char *buf)