Commit 015bf4df authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Kalle Valo
Browse files

wifi: wfx: Remove some dead code 



wait_for_completion_timeout() can not return a <0 value.
So simplify the logic and remove dead code.

-ERESTARTSYS can not be returned by do_wait_for_common() for tasks with
TASK_UNINTERRUPTIBLE, which is the case for wait_for_completion_timeout()

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarJérôme Pouiller <jerome.pouiller@silabs.com>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/809c4a645c8d1306c0d256345515865c40ec731c.1676464422.git.christophe.jaillet@wanadoo.fr
parent 59e6ded5

drivers/net/wireless/silabs/wfx/main.c

+3 −7
Original line number Diff line number Diff line
@@ -358,13 +358,9 @@ int wfx_probe(struct wfx_dev *wdev) 


	wfx_bh_poll_irq(wdev);

	err = wait_for_completion_timeout(&wdev->firmware_ready, 1 * HZ);

	if (err <= 0) {

	if (err == 0) {

		dev_err(wdev->dev, "timeout while waiting for startup indication\n");

		err = -ETIMEDOUT;

		} else if (err == -ERESTARTSYS) {

			dev_info(wdev->dev, "probe interrupted by user\n");

		}

		goto bh_unregister;

	}