Commit 027d052a authored by Dan Carpenter's avatar Dan Carpenter Committed by Rob Clark
Browse files

drm/msm: fix potential NULL dereference in cleanup 



The "msm_obj->node" list needs to be initialized earlier so that the
list_del() in msm_gem_free_object() doesn't experience a NULL pointer
dereference.

Fixes: 6ed0897c ("drm/msm: Fix debugfs deadlock")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20211013081133.GF6010@kili


Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
parent 7425e816

drivers/gpu/drm/msm/msm_gem.c

+1 −0
Original line number Diff line number Diff line
@@ -1132,6 +1132,7 @@ static int msm_gem_new_impl(struct drm_device *dev, 
	msm_obj->flags = flags;

	msm_obj->madv = MSM_MADV_WILLNEED;



	INIT_LIST_HEAD(&msm_obj->node);

	INIT_LIST_HEAD(&msm_obj->vmas);



	*obj = &msm_obj->base;