Commit 03371e4f authored by Lv Ruyi's avatar Lv Ruyi Committed by Dmitry Baryshkov
Browse files

drm/msm/hdmi: fix error check return value of irq_of_parse_and_map() 



The irq_of_parse_and_map() function returns 0 on failure, and does not
return a negative value anyhow, so never enter this conditional branch.

Fixes: f6a8eaca ("drm/msm/mdp5: use irqdomains")
Reported-by: default avatarZeal Robot <zealci@zte.com.cn>
Signed-off-by: default avatarLv Ruyi <lv.ruyi@zte.com.cn>
Reviewed-by: default avatarStephen Boyd <swboyd@chromium.org>
Patchwork: https://patchwork.freedesktop.org/patch/483294/
Link: https://lore.kernel.org/r/20220425091831.3500487-1-lv.ruyi@zte.com.cn


Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
parent a36e5067

drivers/gpu/drm/msm/hdmi/hdmi.c

+3 −3
Original line number Diff line number Diff line
@@ -302,9 +302,9 @@ int msm_hdmi_modeset_init(struct hdmi *hdmi, 
	drm_connector_attach_encoder(hdmi->connector, hdmi->encoder);



	hdmi->irq = irq_of_parse_and_map(pdev->dev.of_node, 0);

	if (hdmi->irq < 0) {

		ret = hdmi->irq;

		DRM_DEV_ERROR(dev->dev, "failed to get irq: %d\n", ret);

	if (!hdmi->irq) {

		ret = -EINVAL;

		DRM_DEV_ERROR(dev->dev, "failed to get irq\n");

		goto fail;

	}