Commit 06b66dc2 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman
Browse files

staging: comedi: cb_pcidas: remove unnecessary check in caldac_8800_write() 



The 'address' passed to this function is actually the comedi channel. This
value will always be less than the subdevice n_chan (which is 8). Remove
the unnecessary sanity check in caldac_8800_write().

Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: default avatarIan Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent dc658fdc

drivers/staging/comedi/drivers/cb_pcidas.c

+0 −6
Original line number Diff line number Diff line
@@ -596,16 +596,10 @@ static int caldac_8800_write(struct comedi_device *dev, unsigned int address, 
			     uint8_t value)

{

	struct cb_pcidas_private *devpriv = dev->private;

	static const int num_caldac_channels = 8;

	static const int bitstream_length = 11;

	unsigned int bitstream = ((address & 0x7) << 8) | value;

	static const int caldac_8800_udelay = 1;



	if (address >= num_caldac_channels) {

		dev_err(dev->class_dev, "illegal caldac channel\n");

		return -1;

	}



	if (value == devpriv->caldac_value[address])

		return 1;