Commit 06f8e071 authored by Rob Herring's avatar Rob Herring Committed by Martin K. Petersen
Browse files

scsi: qlogicpti: sun_esp: Use of_property_read_bool() for boolean properties 



It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property()/of_find_property() functions for reading properties.
Convert reading boolean properties to of_property_read_bool().

Signed-off-by: default avatarRob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20230310144723.1544999-1-robh@kernel.org


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent c5797fda

drivers/scsi/qlogicpti.c

+5 −6
Original line number Diff line number Diff line
@@ -1362,8 +1362,7 @@ static int qpti_sbus_probe(struct platform_device *op) 
	fcode = of_get_property(dp, "isp-fcode", NULL);

	if (fcode && fcode[0])

		printk("(FCode %s)", fcode);

	if (of_find_property(dp, "differential", NULL) != NULL)

		qpti->differential = 1;

	qpti->differential = of_property_read_bool(dp, "differential");



	printk("\nqlogicpti%d: [%s Wide, using %s interface]\n",

		qpti->qpti_id,

drivers/scsi/sun_esp.c

+1 −1
Original line number Diff line number Diff line
@@ -146,7 +146,7 @@ static void esp_get_differential(struct esp *esp) 
	struct device_node *dp;



	dp = op->dev.of_node;

	if (of_find_property(dp, "differential", NULL))

	if (of_property_read_bool(dp, "differential"))

		esp->flags |= ESP_FLAG_DIFFERENTIAL;

	else

		esp->flags &= ~ESP_FLAG_DIFFERENTIAL;