Commit 078e4cf5 authored by Johannes Thumshirn's avatar Johannes Thumshirn Committed by David Sterba
Browse files

btrfs: use __bio_add_page for adding a single page in repair_one_sector 



The btrfs repair bio submission code uses bio_add_page() to add a page
to a newly created bio. bio_add_page() can fail, but the return value is
never checked.

Use __bio_add_page() as adding a single page to a newly created bio is
guaranteed to succeed.

This brings us a step closer to marking bio_add_page() as __must_check.

Reviewed-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
Signed-off-by: default avatarJohannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 7e812f20

fs/btrfs/bio.c

+1 −1
Original line number Diff line number Diff line
@@ -227,7 +227,7 @@ static struct btrfs_failed_bio *repair_one_sector(struct btrfs_bio *failed_bbio, 
	repair_bio = bio_alloc_bioset(NULL, 1, REQ_OP_READ, GFP_NOFS,

				      &btrfs_repair_bioset);

	repair_bio->bi_iter.bi_sector = failed_bbio->saved_iter.bi_sector;

	bio_add_page(repair_bio, bv->bv_page, bv->bv_len, bv->bv_offset);

	__bio_add_page(repair_bio, bv->bv_page, bv->bv_len, bv->bv_offset);



	repair_bbio = btrfs_bio(repair_bio);

	btrfs_bio_init(repair_bbio, failed_bbio->inode, NULL, fbio);