Skip to content
Commit 0801a007 authored by Johan Hovold's avatar Johan Hovold Committed by Jessica Yu
Browse files

module: drop version-attribute alignment

Commit 98562ad8 ("module: explicitly align module_version_attribute
structure") added an alignment attribute to the struct
module_version_attribute type in order to fix an alignment issue on m68k
where the structure is 2-byte aligned while MODULE_VERSION() forced the
__modver section entries to be 4-byte aligned (sizeof(void *)).

This was essentially an alternative fix to the problem addressed by
b4bc8428 ("module: deal with alignment issues in built-in module
versions") which used the array-of-pointer trick to prevent gcc from
increasing alignment of the version attribute entries. And with the
pointer indirection in place there's no need to increase the alignment
of the type.

Link: https://lore.kernel.org/lkml/20201103175711.10731-1-johan@kernel.org


Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarJessica Yu <jeyu@kernel.org>
parent 24b9f0d2
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment