Commit 0819dc72 authored by Yangtao Li's avatar Yangtao Li Committed by Linus Walleij
Browse files

pinctrl: Change to use DEFINE_SHOW_ATTRIBUTE macro 



Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by: default avatarYangtao Li <tiny.windzz@gmail.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 4be1eaf3

drivers/pinctrl/pinconf.c

+4 −25
Original line number Original line Diff line number Diff line
@@ -366,29 +366,8 @@ static int pinconf_groups_show(struct seq_file *s, void *what) 
	return 0;

	return 0;

}

}





static int pinconf_pins_open(struct inode *inode, struct file *file)

DEFINE_SHOW_ATTRIBUTE(pinconf_pins);

{

DEFINE_SHOW_ATTRIBUTE(pinconf_groups);

	return single_open(file, pinconf_pins_show, inode->i_private);

}



static int pinconf_groups_open(struct inode *inode, struct file *file)

{

	return single_open(file, pinconf_groups_show, inode->i_private);

}



static const struct file_operations pinconf_pins_ops = {

	.open		= pinconf_pins_open,

	.read		= seq_read,

	.llseek		= seq_lseek,

	.release	= single_release,

};



static const struct file_operations pinconf_groups_ops = {

	.open		= pinconf_groups_open,

	.read		= seq_read,

	.llseek		= seq_lseek,

	.release	= single_release,

};





#define MAX_NAME_LEN 15

#define MAX_NAME_LEN 15
@@ -613,9 +592,9 @@ void pinconf_init_device_debugfs(struct dentry *devroot, 
			 struct pinctrl_dev *pctldev)

			 struct pinctrl_dev *pctldev)

{

{

	debugfs_create_file("pinconf-pins", S_IFREG | S_IRUGO,

	debugfs_create_file("pinconf-pins", S_IFREG | S_IRUGO,

			    devroot, pctldev, &pinconf_pins_ops);

			    devroot, pctldev, &pinconf_pins_fops);

	debugfs_create_file("pinconf-groups", S_IFREG | S_IRUGO,

	debugfs_create_file("pinconf-groups", S_IFREG | S_IRUGO,

			    devroot, pctldev, &pinconf_groups_ops);

			    devroot, pctldev, &pinconf_groups_fops);

	debugfs_create_file("pinconf-config",  (S_IRUGO | S_IWUSR | S_IWGRP),

	debugfs_create_file("pinconf-config",  (S_IRUGO | S_IWUSR | S_IWGRP),

			    devroot, pctldev, &pinconf_dbg_pinconfig_fops);

			    devroot, pctldev, &pinconf_dbg_pinconfig_fops);

}

}

drivers/pinctrl/pinmux.c

+4 −25
Original line number Original line Diff line number Diff line
@@ -644,37 +644,16 @@ void pinmux_show_setting(struct seq_file *s, 
		   setting->data.mux.func);

		   setting->data.mux.func);

}

}





static int pinmux_functions_open(struct inode *inode, struct file *file)

DEFINE_SHOW_ATTRIBUTE(pinmux_functions);

{

DEFINE_SHOW_ATTRIBUTE(pinmux_pins);

	return single_open(file, pinmux_functions_show, inode->i_private);

}



static int pinmux_pins_open(struct inode *inode, struct file *file)

{

	return single_open(file, pinmux_pins_show, inode->i_private);

}



static const struct file_operations pinmux_functions_ops = {

	.open		= pinmux_functions_open,

	.read		= seq_read,

	.llseek		= seq_lseek,

	.release	= single_release,

};



static const struct file_operations pinmux_pins_ops = {

	.open		= pinmux_pins_open,

	.read		= seq_read,

	.llseek		= seq_lseek,

	.release	= single_release,

};





void pinmux_init_device_debugfs(struct dentry *devroot,

void pinmux_init_device_debugfs(struct dentry *devroot,

			 struct pinctrl_dev *pctldev)

			 struct pinctrl_dev *pctldev)

{

{

	debugfs_create_file("pinmux-functions", S_IFREG | S_IRUGO,

	debugfs_create_file("pinmux-functions", S_IFREG | S_IRUGO,

			    devroot, pctldev, &pinmux_functions_ops);

			    devroot, pctldev, &pinmux_functions_fops);

	debugfs_create_file("pinmux-pins", S_IFREG | S_IRUGO,

	debugfs_create_file("pinmux-pins", S_IFREG | S_IRUGO,

			    devroot, pctldev, &pinmux_pins_ops);

			    devroot, pctldev, &pinmux_pins_fops);

}

}





#endif /* CONFIG_DEBUG_FS */

#endif /* CONFIG_DEBUG_FS */