Commit 0835d1e6 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by David Sterba
Browse files

btrfs: remove the return value from extent_write_locked_range 



The return value from extent_write_locked_range is ignored, and that's
fine because the error reporting happens through the mapping and
ordered_extent.

Reviewed-by: default avatarJosef Bacik <josef@toxicpanda.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent ff20d6a4

fs/btrfs/extent_io.c

+3 −10
Original line number Diff line number Diff line
@@ -2180,11 +2180,10 @@ static int extent_write_cache_pages(struct address_space *mapping, 
 * already been ran (aka, ordered extent inserted) and all pages are still

 * locked.

 */

int extent_write_locked_range(struct inode *inode, u64 start, u64 end,

void extent_write_locked_range(struct inode *inode, u64 start, u64 end,

			       struct writeback_control *wbc)

{

	bool found_error = false;

	int first_error = 0;

	int ret = 0;

	struct address_space *mapping = inode->i_mapping;

	struct btrfs_fs_info *fs_info = btrfs_sb(inode->i_sb);
@@ -2234,20 +2233,14 @@ int extent_write_locked_range(struct inode *inode, u64 start, u64 end, 
			mapping_set_error(page->mapping, ret);

		}

		btrfs_page_unlock_writer(fs_info, page, cur, cur_len);

		if (ret < 0) {

		if (ret < 0)

			found_error = true;

			first_error = ret;

		}

next_page:

		put_page(page);

		cur = cur_end + 1;

	}



	submit_write_bio(&bio_ctrl, found_error ? ret : 0);



	if (found_error)

		return first_error;

	return ret;

}



int extent_writepages(struct address_space *mapping,

fs/btrfs/extent_io.h

+2 −2
Original line number Diff line number Diff line
@@ -177,7 +177,7 @@ int try_release_extent_mapping(struct page *page, gfp_t mask); 
int try_release_extent_buffer(struct page *page);



int btrfs_read_folio(struct file *file, struct folio *folio);

int extent_write_locked_range(struct inode *inode, u64 start, u64 end,

void extent_write_locked_range(struct inode *inode, u64 start, u64 end,

			       struct writeback_control *wbc);

int extent_writepages(struct address_space *mapping,

		      struct writeback_control *wbc);