Commit 084e2640 authored by Luben Tuikov's avatar Luben Tuikov Committed by Alex Deucher
Browse files

drm/amdgpu: Fix check for RAS support 



Use positive logic to check for RAS
support. Rename the function to actually indicate
what it is testing for. Essentially, make the
function a predicate with the correct name.

Cc: Stanley Yang <Stanley.Yang@amd.com>
Cc: Alexander Deucher <Alexander.Deucher@amd.com>
Signed-off-by: default avatarLuben Tuikov <luben.tuikov@amd.com>
Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 4711c033

drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

+6 −9
Original line number Diff line number Diff line
@@ -1933,15 +1933,12 @@ int amdgpu_ras_request_reset_on_boot(struct amdgpu_device *adev, 
	return 0;

}



static int amdgpu_ras_check_asic_type(struct amdgpu_device *adev)

static bool amdgpu_ras_asic_supported(struct amdgpu_device *adev)

{

	if (adev->asic_type != CHIP_VEGA10 &&

		adev->asic_type != CHIP_VEGA20 &&

		adev->asic_type != CHIP_ARCTURUS &&

		adev->asic_type != CHIP_SIENNA_CICHLID)

		return 1;

	else

		return 0;

	return adev->asic_type == CHIP_VEGA10 ||

		adev->asic_type == CHIP_VEGA20 ||

		adev->asic_type == CHIP_ARCTURUS ||

		adev->asic_type == CHIP_SIENNA_CICHLID;

}



/*
@@ -1960,7 +1957,7 @@ static void amdgpu_ras_check_supported(struct amdgpu_device *adev, 
	*supported = 0;



	if (amdgpu_sriov_vf(adev) || !adev->is_atom_fw ||

		amdgpu_ras_check_asic_type(adev))

	    !amdgpu_ras_asic_supported(adev))

		return;



	if (amdgpu_atomfirmware_mem_ecc_supported(adev)) {