Commit 08874fdd authored by Sylwester Nawrocki's avatar Sylwester Nawrocki Committed by Mauro Carvalho Chehab
Browse files

media: exynos4-is: Fix kernel-doc entries in fimc-is.h 



Fixes scripts/kernel-doc warnings:

fimc-is.h:286: warning: Function parameter or member 'fw' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'memory' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'f_w' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'isp' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'sensor' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'setfile' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'ctrl_handler' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'irq' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'sensor_index' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'i2h_cmd' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'h2i_cmd' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'fd_header' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'config' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'config_index' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'is_p_region' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'is_dma_p_region' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'is_shared_region' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'af' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'debugfs_entry' not described in 'fimc_is'

The f_w field is unused so remove it.

Reported-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarSylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent b24bc3ab

drivers/media/platform/exynos4-is/fimc-is.h

+19 −2
Original line number Diff line number Diff line
@@ -232,15 +232,33 @@ struct chain_config { 
 * struct fimc_is - fimc-is data structure

 * @pdev: pointer to FIMC-IS platform device

 * @pctrl: pointer to pinctrl structure for this device

 * @v4l2_dev: pointer to top the level v4l2_device

 * @v4l2_dev: pointer to the top level v4l2_device

 * @fw: data structure describing the FIMC-IS firmware binary

 * @memory: memory region assigned for the FIMC-IS (firmware)

 * @isp: the ISP block data structure

 * @sensor: fimc-is sensor subdevice array

 * @setfile: descriptor of the imaging pipeline calibration data

 * @ctrl_handler: the v4l2 controls handler

 * @lock: mutex serializing video device and the subdev operations

 * @slock: spinlock protecting this data structure and the hw registers

 * @clocks: FIMC-LITE gate clock

 * @regs: MCUCTL mmapped registers region

 * @pmu_regs: PMU ISP mmapped registers region

 * @irq: FIMC-IS interrupt

 * @irq_queue: interrupt handling waitqueue

 * @lpm: low power mode flag

 * @state: internal driver's state flags

 * @sensor_index: image sensor index for the firmware

 * @i2h_cmd: FIMC-IS to the host (CPU) mailbox command data structure

 * @h2i_cmd: the host (CPU) to FIMC-IS mailbox command data structure

 * @fd_header: the face detection result data structure

 * @config: shared HW pipeline configuration data

 * @config_index: index to the @config entry currently in use

 * @is_p_region: pointer to the shared parameter memory region

 * @is_dma_p_region: DMA address of the shared parameter memory region

 * @is_shared_region: pointer to the IS shared region data structure

 * @af: auto focus data

 * @debugfs_entry: debugfs entry for the firmware log

 */

struct fimc_is {

	struct platform_device		*pdev;
@@ -249,7 +267,6 @@ struct fimc_is { 


	struct fimc_is_firmware		fw;

	struct fimc_is_memory		memory;

	struct firmware			*f_w;



	struct fimc_isp			isp;

	struct fimc_is_sensor		sensor[FIMC_IS_SENSORS_NUM];