Commit 08acbdd6 authored by Richard Weinberger's avatar Richard Weinberger
Browse files

Revert "UBIFS: Fix potential integer overflow in allocation" 



This reverts commit 353748a3.
It bypassed the linux-mtd review process and fixes the issue not as it
should.

Cc: Kees Cook <keescook@chromium.org>
Cc: Silvio Cesare <silvio.cesare@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
parent 49d2e05f

fs/ubifs/journal.c

+2 −3
Original line number Original line Diff line number Diff line
@@ -1288,11 +1288,10 @@ static int truncate_data_node(const struct ubifs_info *c, const struct inode *in 
			      int *new_len)

			      int *new_len)

{

{

	void *buf;

	void *buf;

	int err, compr_type;

	int err, dlen, compr_type, out_len, old_dlen;

	u32 dlen, out_len, old_dlen;





	out_len = le32_to_cpu(dn->size);

	out_len = le32_to_cpu(dn->size);

	buf = kmalloc_array(out_len, WORST_COMPR_FACTOR, GFP_NOFS);

	buf = kmalloc(out_len * WORST_COMPR_FACTOR, GFP_NOFS);

	if (!buf)

	if (!buf)

		return -ENOMEM;

		return -ENOMEM;