Commit 08bc2dbc authored by Adrian Bunk's avatar Adrian Bunk Committed by Steven Whitehouse
Browse files

[GFS2] [-mm patch] fs/gfs2/: possible cleanups 



This patch contains the following possible cleanups:
- make needlessly global code static
- #if 0 unused functions
- remove the following global function that was both unused and
  unimplemented:
  - super.c: gfs2_do_upgrade()

Signed-off-by: default avatarAdrian Bunk <bunk@stusta.de>
Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
parent c56b39cd

fs/gfs2/bmap.c

+2 −1
Original line number Diff line number Diff line
@@ -59,7 +59,7 @@ struct strip_mine { 
 *

 * Returns: errno

 */



#if 0

int gfs2_unstuffer_sync(struct gfs2_inode *ip, struct buffer_head *dibh,

			uint64_t block, void *private)

{
@@ -77,6 +77,7 @@ int gfs2_unstuffer_sync(struct gfs2_inode *ip, struct buffer_head *dibh, 


	return error;

}

#endif  /*  0  */



/**

 * gfs2_unstuff_dinode - Unstuff a dinode when the data has grown too big

fs/gfs2/bmap.h

+0 −2
Original line number Diff line number Diff line
@@ -13,8 +13,6 @@ 
typedef int (*gfs2_unstuffer_t) (struct gfs2_inode * ip,

				 struct buffer_head * dibh, uint64_t block,

				 void *private);

int gfs2_unstuffer_sync(struct gfs2_inode *ip, struct buffer_head *dibh,

			uint64_t block, void *private);

int gfs2_unstuff_dinode(struct gfs2_inode *ip, gfs2_unstuffer_t unstuffer,

			void *private);

fs/gfs2/dir.c

+4 −4
Original line number Diff line number Diff line
@@ -669,7 +669,7 @@ static void dirent_del(struct gfs2_inode *dip, struct buffer_head *bh, 
 * Takes a dent from which to grab space as an argument. Returns the

 * newly created dent.

 */

struct gfs2_dirent *gfs2_init_dirent(struct inode *inode,

static struct gfs2_dirent *gfs2_init_dirent(struct inode *inode,

					    struct gfs2_dirent *dent,

					    const struct qstr *name,

					    struct buffer_head *bh)

fs/gfs2/eaops.c

+1 −1
Original line number Diff line number Diff line
@@ -167,7 +167,7 @@ static int system_eo_remove(struct gfs2_inode *ip, struct gfs2_ea_request *er) 
	return gfs2_ea_remove_i(ip, er);

}



struct gfs2_eattr_operations gfs2_user_eaops = {

static struct gfs2_eattr_operations gfs2_user_eaops = {

	.eo_get = user_eo_get,

	.eo_set = user_eo_set,

	.eo_remove = user_eo_remove,

fs/gfs2/eaops.h

+0 −1
Original line number Diff line number Diff line
@@ -21,7 +21,6 @@ struct gfs2_eattr_operations { 


unsigned int gfs2_ea_name2type(const char *name, char **truncated_name);



extern struct gfs2_eattr_operations gfs2_user_eaops;

extern struct gfs2_eattr_operations gfs2_system_eaops;



extern struct gfs2_eattr_operations *gfs2_ea_ops[];