Commit 08f50907 authored by Frans Meulenbroeks's avatar Frans Meulenbroeks Committed by Guenter Roeck
Browse files

hwmon: (adm1029) fix checkpatch issues 



fixed:
ERROR: space prohibited after that open parenthesis '('
+#define DIV_FROM_REG(val)	( 1 << (((val) >> 6) - 1))

WARNING: simple_strtol is obsolete, use kstrtol instead
+	long val = simple_strtol(buf, NULL, 10);

ERROR: do not use assignment in if condition
+	if ((err = sysfs_create_group(&client->dev.kobj, &adm1029_group)))

Signed-off-by: default avatarFrans Meulenbroeks <fransmeulenbroeks@gmail.com>
Signed-off-by: default avatarGuenter Roeck <guenter.roeck@ericsson.com>
parent 4d7c5d4f

drivers/hwmon/adm1029.c

+7 −3
Original line number Diff line number Diff line
@@ -200,8 +200,11 @@ static ssize_t set_fan_div(struct device *dev, 
	struct i2c_client *client = to_i2c_client(dev);

	struct adm1029_data *data = i2c_get_clientdata(client);

	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);

	long val = simple_strtol(buf, NULL, 10);

	u8 reg;

	long val;

	int ret = kstrtol(buf, 10, &val);

	if (ret < 0)

		return ret;



	mutex_lock(&data->update_lock);
@@ -355,7 +358,8 @@ static int adm1029_probe(struct i2c_client *client, 
	}



	/* Register sysfs hooks */

	if ((err = sysfs_create_group(&client->dev.kobj, &adm1029_group)))

	err = sysfs_create_group(&client->dev.kobj, &adm1029_group);

	if (err)

		goto exit_free;



	data->hwmon_dev = hwmon_device_register(&client->dev);