Unverified Commit 093513b8 authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Mark Brown
Browse files

ASoC: codecs: wm0010: use DECLARE_COMPLETION_ONSTACK() macro 



Follow recommendation in Documentation/scheduler/completion.rst and
use macro to declare local 'struct completion'

Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Acked-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20200813175442.59067-1-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 6bc37d32

sound/soc/codecs/wm0010.c

+1 −2
Original line number Original line Diff line number Diff line
@@ -346,7 +346,7 @@ static int wm0010_firmware_load(const char *name, struct snd_soc_component *comp 
	struct list_head xfer_list;

	struct list_head xfer_list;

	struct wm0010_boot_xfer *xfer;

	struct wm0010_boot_xfer *xfer;

	int ret;

	int ret;

	struct completion done;

	DECLARE_COMPLETION_ONSTACK(done);

	const struct firmware *fw;

	const struct firmware *fw;

	const struct dfw_binrec *rec;

	const struct dfw_binrec *rec;

	const struct dfw_inforec *inforec;

	const struct dfw_inforec *inforec;
@@ -370,7 +370,6 @@ static int wm0010_firmware_load(const char *name, struct snd_soc_component *comp 
	wm0010->boot_failed = false;

	wm0010->boot_failed = false;

	if (WARN_ON(!list_empty(&xfer_list)))

	if (WARN_ON(!list_empty(&xfer_list)))

		return -EINVAL;

		return -EINVAL;

	init_completion(&done);





	/* First record should be INFO */

	/* First record should be INFO */

	if (rec->command != DFW_CMD_INFO) {

	if (rec->command != DFW_CMD_INFO) {