Commit 0a139358 authored by Marijn Suijten's avatar Marijn Suijten Committed by Lee Jones
Browse files

backlight: qcom-wled: Use cpu_to_le16 macro to perform conversion 



The kernel already provides appropriate primitives to perform endianness
conversion which should be used in favour of manual bit-wrangling.

Signed-off-by: default avatarMarijn Suijten <marijn.suijten@somainline.org>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Reviewed-by: default avatarDaniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20211115203459.1634079-4-marijn.suijten@somainline.org
parent e29e24bd

drivers/video/backlight/qcom-wled.c

+11 −12
Original line number Diff line number Diff line
@@ -231,14 +231,14 @@ struct wled { 
static int wled3_set_brightness(struct wled *wled, u16 brightness)

{

	int rc, i;

	u8 v[2];

	__le16 v;



	v[0] = brightness & 0xff;

	v[1] = (brightness >> 8) & 0xf;

	v = cpu_to_le16(brightness & WLED3_SINK_REG_BRIGHT_MAX);



	for (i = 0;  i < wled->cfg.num_strings; ++i) {

		rc = regmap_bulk_write(wled->regmap, wled->ctrl_addr +

				       WLED3_SINK_REG_BRIGHT(i), v, 2);

				       WLED3_SINK_REG_BRIGHT(i),

				       &v, sizeof(v));

		if (rc < 0)

			return rc;

	}
@@ -250,18 +250,18 @@ static int wled4_set_brightness(struct wled *wled, u16 brightness) 
{

	int rc, i;

	u16 low_limit = wled->max_brightness * 4 / 1000;

	u8 v[2];

	__le16 v;



	/* WLED4's lower limit of operation is 0.4% */

	if (brightness > 0 && brightness < low_limit)

		brightness = low_limit;



	v[0] = brightness & 0xff;

	v[1] = (brightness >> 8) & 0xf;

	v = cpu_to_le16(brightness & WLED3_SINK_REG_BRIGHT_MAX);



	for (i = 0;  i < wled->cfg.num_strings; ++i) {

		rc = regmap_bulk_write(wled->regmap, wled->sink_addr +

				       WLED4_SINK_REG_BRIGHT(i), v, 2);

				       WLED4_SINK_REG_BRIGHT(i),

				       &v, sizeof(v));

		if (rc < 0)

			return rc;

	}
@@ -273,21 +273,20 @@ static int wled5_set_brightness(struct wled *wled, u16 brightness) 
{

	int rc, offset;

	u16 low_limit = wled->max_brightness * 1 / 1000;

	u8 v[2];

	__le16 v;



	/* WLED5's lower limit is 0.1% */

	if (brightness < low_limit)

		brightness = low_limit;



	v[0] = brightness & 0xff;

	v[1] = (brightness >> 8) & 0x7f;

	v = cpu_to_le16(brightness & WLED5_SINK_REG_BRIGHT_MAX_15B);



	offset = (wled->cfg.mod_sel == MOD_A) ?

		  WLED5_SINK_REG_MOD_A_BRIGHTNESS_LSB :

		  WLED5_SINK_REG_MOD_B_BRIGHTNESS_LSB;



	rc = regmap_bulk_write(wled->regmap, wled->sink_addr + offset,

			       v, 2);

			       &v, sizeof(v));

	return rc;

}