Commit 0b5cd6c3 authored Jan 17, 2021 by Pavel Begunkov Committed by Jens Axboe Jan 16, 2021

io_uring: fix skipping disabling sqo on exec



If there are no requests at the time __io_uring_task_cancel() is called,
tctx_inflight() returns zero and and it terminates not getting a chance
to go through __io_uring_files_cancel() and do
io_disable_sqo_submit(). And we absolutely want them disabled by the
time cancellation ends.

Reported-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Fixes: d9d05217 ("io_uring: stop SQPOLL submit on creator's death")
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 4325cb49

fs/io_uring.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -9085,6 +9085,10 @@ void __io_uring_task_cancel(void)
		/* make sure overflow events are dropped */
		atomic_inc(&tctx->in_idle);

		/* trigger io_disable_sqo_submit() */
		if (tctx->sqpoll)
		__io_uring_files_cancel(NULL);

		do {
		/* read completions before cancelations */
		inflight = tctx_inflight(tctx);