Commit 0ba02c4d authored by Alex Elder's avatar Alex Elder Committed by Greg Kroah-Hartman
Browse files

greybus: don't use 0 as an operation id 



Stop allowing 0x0000 to be used as an operation id.  That id will be
reserved for use by operations that will return no response message.

Signed-off-by: default avatarAlex Elder <elder@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <greg@kroah.com>
parent c939c2f8

drivers/staging/greybus/operation.c

+3 −2
Original line number Diff line number Diff line
@@ -151,10 +151,11 @@ static void gb_pending_operation_insert(struct gb_operation *operation) 


	/*

	 * Assign the operation's id and move it into its

	 * connection's pending list.

	 * connection's pending list.  Zero is a reserved operation

	 * id.

	 */

	spin_lock_irq(&gb_operations_lock);

	operation->id = ++connection->op_cycle;

	operation->id = ++connection->op_cycle % U16_MAX + 1;

	list_move_tail(&operation->links, &connection->pending);

	spin_unlock_irq(&gb_operations_lock);