Commit 0bde59c1 authored by Stefano Garzarella's avatar Stefano Garzarella Committed by Michael S. Tsirkin
Browse files

vhost-vdpa: set v->config_ctx to NULL if eventfd_ctx_fdget() fails 



In vhost_vdpa_set_config_call() if eventfd_ctx_fdget() fails the
'v->config_ctx' contains an error instead of a valid pointer.

Since we consider 'v->config_ctx' valid if it is not NULL, we should
set it to NULL in this case to avoid to use an invalid pointer in
other functions such as vhost_vdpa_config_put().

Fixes: 776f3950 ("vhost_vdpa: Support config interrupt in vdpa")
Cc: lingshan.zhu@intel.com
Cc: stable@vger.kernel.org
Signed-off-by: default avatarStefano Garzarella <sgarzare@redhat.com>
Link: https://lore.kernel.org/r/20210311135257.109460-3-sgarzare@redhat.com


Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Acked-by: default avatarJason Wang <jasowang@redhat.com>
parent f6bbf001

drivers/vhost/vdpa.c

+6 −2
Original line number Diff line number Diff line
@@ -331,8 +331,12 @@ static long vhost_vdpa_set_config_call(struct vhost_vdpa *v, u32 __user *argp) 
	if (!IS_ERR_OR_NULL(ctx))

		eventfd_ctx_put(ctx);



	if (IS_ERR(v->config_ctx))

		return PTR_ERR(v->config_ctx);

	if (IS_ERR(v->config_ctx)) {

		long ret = PTR_ERR(v->config_ctx);



		v->config_ctx = NULL;

		return ret;

	}



	v->vdpa->config->set_config_cb(v->vdpa, &cb);