Commit 0ca870ca authored by Marijn Suijten's avatar Marijn Suijten Committed by Dmitry Baryshkov
Browse files

drm/msm/dsi: Appropriately set dsc->mux_word_size based on bpc 



This field is currently unread but will come into effect when duplicated
code below is migrated to call drm_dsc_compute_rc_parameters(), which
uses the bpc-dependent value of the local variable mux_words_size in
much the same way.

The hardcoded constant seems to be a remnant from the `/* bpc 8 */`
comment right above, indicating that this group of field assignments is
applicable to bpc = 8 exclusively and should probably bail out on
different bpc values, until constants for other bpc values are added (or
the current ones are confirmed to be correct across multiple bpc's).

Fixes: b9080324 ("drm/msm/dsi: add support for dsc data")
Reviewed-by: default avatarAbhinav Kumar <quic_abhinavk@quicinc.com>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: default avatarMarijn Suijten <marijn.suijten@somainline.org>
Patchwork: https://patchwork.freedesktop.org/patch/508943/
Link: https://lore.kernel.org/r/20221026182824.876933-6-marijn.suijten@somainline.org


Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
parent e443459e

drivers/gpu/drm/msm/dsi/dsi_host.c

+1 −1
Original line number Diff line number Diff line
@@ -1786,6 +1786,7 @@ static int dsi_populate_dsc_params(struct drm_dsc_config *dsc) 
	if (dsc->bits_per_component == 12)

		mux_words_size = 64;



	dsc->mux_word_size = mux_words_size;

	dsc->initial_xmit_delay = 512;

	dsc->initial_scale_value = 32;

	dsc->first_line_bpg_offset = 12;
@@ -1796,7 +1797,6 @@ static int dsi_populate_dsc_params(struct drm_dsc_config *dsc) 
	dsc->flatness_max_qp = 12;

	dsc->rc_quant_incr_limit0 = 11;

	dsc->rc_quant_incr_limit1 = 11;

	dsc->mux_word_size = DSC_MUX_WORD_SIZE_8_10_BPC;



	/* FIXME: need to call drm_dsc_compute_rc_parameters() so that rest of

	 * params are calculated