Commit 0e906607 authored by Florian Westphal's avatar Florian Westphal Committed by Pablo Neira Ayuso
Browse files

netfilter: nf_conntrack_netbios_ns: fix helper module alias 



The helper gets registered as 'netbios-ns', not netbios_ns.
Intentionally not adding a fixes-tag because i don't want this to go to
stable. This wasn't noticed for a very long time so no so no need to risk
regressions.

Reported-by: default avatarYi Chen <yiche@redhat.com>
Signed-off-by: default avatarFlorian Westphal <fw@strlen.de>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent 7d6019b6

net/netfilter/nf_conntrack_netbios_ns.c

+3 −2
Original line number Diff line number Diff line
@@ -20,13 +20,14 @@ 
#include <net/netfilter/nf_conntrack_helper.h>

#include <net/netfilter/nf_conntrack_expect.h>



#define HELPER_NAME	"netbios-ns"

#define NMBD_PORT	137



MODULE_AUTHOR("Patrick McHardy <kaber@trash.net>");

MODULE_DESCRIPTION("NetBIOS name service broadcast connection tracking helper");

MODULE_LICENSE("GPL");

MODULE_ALIAS("ip_conntrack_netbios_ns");

MODULE_ALIAS_NFCT_HELPER("netbios_ns");

MODULE_ALIAS_NFCT_HELPER(HELPER_NAME);



static unsigned int timeout __read_mostly = 3;

module_param(timeout, uint, 0400);
@@ -44,7 +45,7 @@ static int netbios_ns_help(struct sk_buff *skb, unsigned int protoff, 
}



static struct nf_conntrack_helper helper __read_mostly = {

	.name			= "netbios-ns",

	.name			= HELPER_NAME,

	.tuple.src.l3num	= NFPROTO_IPV4,

	.tuple.src.u.udp.port	= cpu_to_be16(NMBD_PORT),

	.tuple.dst.protonum	= IPPROTO_UDP,