Commit 0eb198d2 authored by Hannes Reinecke's avatar Hannes Reinecke Committed by Martin K. Petersen
Browse files

scsi: acornscsi: Use standard defines 

Use midlayer-defined values and drop the non-existing QUEUE_FULL case; we
are checking the SCSI messages in the switch statement, and QUEUE_FULL is a
SCSI status hence it can never occur here.

Link: https://lore.kernel.org/r/20210113090500.129644-11-hare@suse.de


Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent eb74b932

drivers/scsi/arm/acornscsi.c

+2 −12
Original line number Diff line number Diff line
@@ -144,12 +144,6 @@ 
#define VER_MINOR 0

#define VER_PATCH 6



#ifndef ABORT_TAG

#define ABORT_TAG 0xd

#else

#error "Yippee!  ABORT TAG is now defined!  Remove this error!"

#endif



#ifdef USE_DMAC

/*

 * DMAC setup parameters
@@ -1490,8 +1484,8 @@ void acornscsi_message(AS_Host *host) 
    }



    switch (message[0]) {

    case ABORT:

    case ABORT_TAG:

    case ABORT_TASK_SET:

    case ABORT_TASK:

    case COMMAND_COMPLETE:

	if (host->scsi.phase != PHASE_STATUSIN) {

	    printk(KERN_ERR "scsi%d.%c: command complete following non-status in phase?\n",
@@ -1596,10 +1590,6 @@ void acornscsi_message(AS_Host *host) 
	}

	break;



    case QUEUE_FULL:

	/* TODO: target queue is full */

	break;



    case SIMPLE_QUEUE_TAG:

	/* tag queue reconnect... message[1] = queue tag.  Print something to indicate something happened! */

	printk("scsi%d.%c: reconnect queue tag %02X\n",