Commit 0f935dbe authored Sep 25, 2015 by Eric Dumazet Committed by David S. Miller Sep 25, 2015

tcp: constify tcp_v{4|6}_send_synack() socket argument



This documents fact that listener lock might not be held
at the time SYNACK are sent.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 1c1e9d2b

include/net/tcp.h

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1717,7 +1717,7 @@ struct tcp_request_sock_ops {
	const struct request_sock *req,		const struct request_sock *req,
	bool *strict);		bool *strict);
	__u32 (init_seq)(const struct sk_buff skb);		__u32 (init_seq)(const struct sk_buff skb);
	int (send_synack)(struct sock sk, struct dst_entry *dst,		int (send_synack)(const struct sock sk, struct dst_entry *dst,
	struct flowi fl, struct request_sock req,		struct flowi fl, struct request_sock req,
	u16 queue_mapping, struct tcp_fastopen_cookie *foc);		u16 queue_mapping, struct tcp_fastopen_cookie *foc);
	void (queue_hash_add)(struct sock sk, struct request_sock *req,		void (queue_hash_add)(struct sock sk, struct request_sock *req,

net/ipv4/tcp_ipv4.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -818,7 +818,7 @@ static void tcp_v4_reqsk_send_ack(struct sock sk, struct sk_buff skb,
	* This still operates on a request_sock only, not on a big		* This still operates on a request_sock only, not on a big
	* socket.		* socket.
	*/		*/
	static int tcp_v4_send_synack(struct sock sk, struct dst_entry dst,		static int tcp_v4_send_synack(const struct sock sk, struct dst_entry dst,
	struct flowi *fl,		struct flowi *fl,
	struct request_sock *req,		struct request_sock *req,
	u16 queue_mapping,		u16 queue_mapping,

net/ipv6/tcp_ipv6.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -434,7 +434,7 @@ static void tcp_v6_err(struct sk_buff skb, struct inet6_skb_parm opt,
	}		}


	static int tcp_v6_send_synack(struct sock sk, struct dst_entry dst,		static int tcp_v6_send_synack(const struct sock sk, struct dst_entry dst,
	struct flowi *fl,		struct flowi *fl,
	struct request_sock *req,		struct request_sock *req,
	u16 queue_mapping,		u16 queue_mapping,