Commit 1040c99d authored by Mike Christie's avatar Mike Christie Committed by James Bottomley
Browse files

[SCSI] libiscsi: Drop host lock in queuecommand 



The driver does not need the host lock in queuecommand so drop it.

Signed-off-by: default avatarMike Christie <michaelc@cs.wisc.edu>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
parent c1635cb7

drivers/scsi/libiscsi.c

+5 −1
Original line number Diff line number Diff line
@@ -1010,8 +1010,9 @@ int iscsi_queuecommand(struct scsi_cmnd *sc, void (*done)(struct scsi_cmnd *)) 
	sc->SCp.ptr = NULL;



	host = sc->device->host;

	session = iscsi_hostdata(host->hostdata);

	spin_unlock(host->host_lock);



	session = iscsi_hostdata(host->hostdata);

	spin_lock(&session->lock);



	/*
@@ -1077,11 +1078,13 @@ int iscsi_queuecommand(struct scsi_cmnd *sc, void (*done)(struct scsi_cmnd *)) 
	spin_unlock(&session->lock);



	scsi_queue_work(host, &conn->xmitwork);

	spin_lock(host->host_lock);

	return 0;



reject:

	spin_unlock(&session->lock);

	debug_scsi("cmd 0x%x rejected (%d)\n", sc->cmnd[0], reason);

	spin_lock(host->host_lock);

	return SCSI_MLQUEUE_HOST_BUSY;



fault:
@@ -1091,6 +1094,7 @@ int iscsi_queuecommand(struct scsi_cmnd *sc, void (*done)(struct scsi_cmnd *)) 
	sc->result = (DID_NO_CONNECT << 16);

	scsi_set_resid(sc, scsi_bufflen(sc));

	sc->scsi_done(sc);

	spin_lock(host->host_lock);

	return 0;

}

EXPORT_SYMBOL_GPL(iscsi_queuecommand);