Commit 10d9dcf6 authored by Kent Overstreet's avatar Kent Overstreet
Browse files

bcache: Fix moving_pred() 



Avoid a potential null pointer deref (e.g. from check keys for cache misses)

Signed-off-by: default avatarKent Overstreet <kmo@daterainc.com>
parent da415a09

drivers/md/bcache/movinggc.c

+3 −5
Original line number Original line Diff line number Diff line
@@ -24,12 +24,10 @@ static bool moving_pred(struct keybuf *buf, struct bkey *k) 
					   moving_gc_keys);

					   moving_gc_keys);

	unsigned i;

	unsigned i;





	for (i = 0; i < KEY_PTRS(k); i++) {

	for (i = 0; i < KEY_PTRS(k); i++)

		struct bucket *g = PTR_BUCKET(c, k, i);

		if (ptr_available(c, k, i) &&



		    GC_MOVE(PTR_BUCKET(c, k, i)))

		if (GC_MOVE(g))

			return true;

			return true;

	}





	return false;

	return false;

}

}