Commit 11edbb19 authored Jan 26, 2021 by Lee Jones Committed by Jason Gunthorpe Jan 28, 2021

RDMA/hw/hfi1/qp: Fix some formatting issues and demote kernel-doc abuse

Fixes the following W=1 kernel build warning(s):

drivers/infiniband/hw/hfi1/qp.c:195: warning: Function parameter or member 'dev' not described in 'verbs_mtu_enum_to_int'
drivers/infiniband/hw/hfi1/qp.c:195: warning: Function parameter or member 'mtu' not described in 'verbs_mtu_enum_to_int'
drivers/infiniband/hw/hfi1/qp.c:306: warning: Function parameter or member 'qp' not described in 'hfi1_setup_wqe'
drivers/infiniband/hw/hfi1/qp.c:306: warning: Function parameter or member 'wqe' not described in 'hfi1_setup_wqe'
drivers/infiniband/hw/hfi1/qp.c:306: warning: Function parameter or member 'call_send' not described in 'hfi1_setup_wqe'
drivers/infiniband/hw/hfi1/qp.c:922: warning: Function parameter or member 'qp' not described in 'hfi1_qp_iter_cb'
drivers/infiniband/hw/hfi1/qp.c:922: warning: Function parameter or member 'v' not described in 'hfi1_qp_iter_cb'

Link: https://lore.kernel.org/r/20210126124732.3320971-13-lee.jones@linaro.org

Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Cc: Doug Ledford <dledford@redhat.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: linux-rdma@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>

parent 6993fce4

drivers/infiniband/hw/hfi1/qp.c

+7 −7

Original line number	Diff line number	Diff line
		@@ -186,7 +186,7 @@ static void flush_iowait(struct rvt_qp *qp)
		write_sequnlock_irqrestore(lock, flags);
		}

		/**
		/*
		* This function is what we would push to the core layer if we wanted to be a
		* "first class citizen". Instead we hide this here and rely on Verbs ULPs
		* to blindly pass the MTU enum value from the PathRecord to us.
		@@ -289,9 +289,9 @@ void hfi1_modify_qp(struct rvt_qp qp, struct ib_qp_attr attr,

		/**
		* hfi1_setup_wqe - set up the wqe
		* @qp - The qp
		* @wqe - The built wqe
		* @call_send - Determine if the send should be posted or scheduled.
		* @qp: The qp
		* @wqe: The built wqe
		* @call_send: Determine if the send should be posted or scheduled.
		*
		* Perform setup of the wqe. This is called
		* prior to inserting the wqe into the ring but after
		@@ -595,7 +595,7 @@ struct sdma_engine qp_to_sdma_engine(struct rvt_qp qp, u8 sc5)
		return sde;
		}

		/*
		/**
		* qp_to_send_context - map a qp to a send context
		* @qp: the QP
		* @sc5: the 5 bit sc
		@@ -912,8 +912,8 @@ void notify_error_qp(struct rvt_qp *qp)

		/**
		* hfi1_qp_iter_cb - callback for iterator
		* @qp - the qp
		* @v - the sl in low bits of v
		* @qp: the qp
		* @v: the sl in low bits of v
		*
		* This is called from the iterator callback to work
		* on an individual qp.