Commit 12e6cecd authored by Thierry Reding's avatar Thierry Reding
Browse files

drm: Use const data when creating blob properties 



Creating a blob property will always copy the input data so the data
that is passed in can be const.

Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
parent ecbbe59b

drivers/gpu/drm/drm_crtc.c

+3 −3
Original line number Original line Diff line number Diff line
@@ -3940,7 +3940,7 @@ int drm_mode_getproperty_ioctl(struct drm_device *dev, 




static struct drm_property_blob *

static struct drm_property_blob *

drm_property_create_blob(struct drm_device *dev, size_t length,

drm_property_create_blob(struct drm_device *dev, size_t length,

			 void *data)

			 const void *data)

{

{

	struct drm_property_blob *blob;

	struct drm_property_blob *blob;

	int ret;

	int ret;
@@ -4021,7 +4021,7 @@ int drm_mode_getblob_ioctl(struct drm_device *dev, 
}

}





int drm_mode_connector_set_path_property(struct drm_connector *connector,

int drm_mode_connector_set_path_property(struct drm_connector *connector,

					 char *path)

					 const char *path)

{

{

	struct drm_device *dev = connector->dev;

	struct drm_device *dev = connector->dev;

	size_t size = strlen(path) + 1;

	size_t size = strlen(path) + 1;
@@ -4051,7 +4051,7 @@ EXPORT_SYMBOL(drm_mode_connector_set_path_property); 
 * Zero on success, errno on failure.

 * Zero on success, errno on failure.

 */

 */

int drm_mode_connector_update_edid_property(struct drm_connector *connector,

int drm_mode_connector_update_edid_property(struct drm_connector *connector,

					    struct edid *edid)

					    const struct edid *edid)

{

{

	struct drm_device *dev = connector->dev;

	struct drm_device *dev = connector->dev;

	size_t size;

	size_t size;

drivers/gpu/drm/i915/intel_dp_mst.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -393,7 +393,7 @@ static void intel_connector_remove_from_fbdev(struct intel_connector *connector) 
#endif

#endif

}

}





static struct drm_connector *intel_dp_add_mst_connector(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp_mst_port *port, char *pathprop)

static struct drm_connector *intel_dp_add_mst_connector(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp_mst_port *port, const char *pathprop)

{

{

	struct intel_dp *intel_dp = container_of(mgr, struct intel_dp, mst_mgr);

	struct intel_dp *intel_dp = container_of(mgr, struct intel_dp, mst_mgr);

	struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);

	struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);

include/drm/drm_crtc.h

+2 −2
Original line number Original line Diff line number Diff line
@@ -978,9 +978,9 @@ extern void drm_mode_config_reset(struct drm_device *dev); 
extern void drm_mode_config_cleanup(struct drm_device *dev);

extern void drm_mode_config_cleanup(struct drm_device *dev);





extern int drm_mode_connector_set_path_property(struct drm_connector *connector,

extern int drm_mode_connector_set_path_property(struct drm_connector *connector,

						char *path);

						const char *path);

extern int drm_mode_connector_update_edid_property(struct drm_connector *connector,

extern int drm_mode_connector_update_edid_property(struct drm_connector *connector,

						struct edid *edid);

						   const struct edid *edid);





static inline bool drm_property_type_is(struct drm_property *property,

static inline bool drm_property_type_is(struct drm_property *property,

		uint32_t type)

		uint32_t type)

include/drm/drm_dp_mst_helper.h

+1 −1
Original line number Original line Diff line number Diff line
@@ -371,7 +371,7 @@ struct drm_dp_sideband_msg_tx { 
struct drm_dp_mst_topology_mgr;

struct drm_dp_mst_topology_mgr;

struct drm_dp_mst_topology_cbs {

struct drm_dp_mst_topology_cbs {

	/* create a connector for a port */

	/* create a connector for a port */

	struct drm_connector *(*add_connector)(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp_mst_port *port, char *path);

	struct drm_connector *(*add_connector)(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp_mst_port *port, const char *path);

	void (*destroy_connector)(struct drm_dp_mst_topology_mgr *mgr,

	void (*destroy_connector)(struct drm_dp_mst_topology_mgr *mgr,

				  struct drm_connector *connector);

				  struct drm_connector *connector);

	void (*hotplug)(struct drm_dp_mst_topology_mgr *mgr);

	void (*hotplug)(struct drm_dp_mst_topology_mgr *mgr);