Commit 13202ebf authored by Niklas Cassel's avatar Niklas Cassel Committed by Martin K. Petersen
Browse files

scsi: sd_zbc: Simplify zone full condition check 

According to the ZBC (and ZAC) specification, a zone that has Zone Type set
to Conventional, must also have its Zone Condition set to "Not Write
Pointer".

Therefore, a conventional zone will never have Zone Condition set to
"Full", which means that we can omit the non-conventional prerequisite from
the zone full condition check.

Link: https://lore.kernel.org/r/20211201142821.64650-1-Niklas.Cassel@wdc.com


Suggested-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: default avatarJohannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: default avatarNiklas Cassel <niklas.cassel@wdc.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent db330286

drivers/scsi/sd_zbc.c

+1 −2
Original line number Diff line number Diff line
@@ -62,8 +62,7 @@ static int sd_zbc_parse_report(struct scsi_disk *sdkp, u8 *buf, 
	zone.capacity = zone.len;

	zone.start = logical_to_sectors(sdp, get_unaligned_be64(&buf[16]));

	zone.wp = logical_to_sectors(sdp, get_unaligned_be64(&buf[24]));

	if (zone.type != ZBC_ZONE_TYPE_CONV &&

	    zone.cond == ZBC_ZONE_COND_FULL)

	if (zone.cond == ZBC_ZONE_COND_FULL)

		zone.wp = zone.start + zone.len;



	ret = cb(&zone, idx, data);