Commit 13d68881 authored by Martin Kaiser's avatar Martin Kaiser Committed by Greg Kroah-Hartman
Browse files

staging: rtl8188eu: rtw_init_cmd_priv never fails 



Change the return type to void. Remove unnecessary error handling.

Signed-off-by: default avatarMartin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20210505202622.11087-2-martin@kaiser.cx


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2752fc41

drivers/staging/rtl8188eu/core/rtw_cmd.c

+1 −2
Original line number Diff line number Diff line
@@ -52,13 +52,12 @@ static struct _cmd_callback rtw_cmd_callback[] = { 
 * No irqsave is necessary.

 */



int rtw_init_cmd_priv(struct cmd_priv *pcmdpriv)

void rtw_init_cmd_priv(struct cmd_priv *pcmdpriv)

{

	init_completion(&pcmdpriv->cmd_queue_comp);

	init_completion(&pcmdpriv->terminate_cmdthread_comp);



	_rtw_init_queue(&pcmdpriv->cmd_queue);

	return _SUCCESS;

}



/*

drivers/staging/rtl8188eu/include/rtw_cmd.h

+1 −1
Original line number Diff line number Diff line
@@ -54,7 +54,7 @@ void rtw_free_cmd_obj(struct cmd_obj *pcmd); 


int rtw_cmd_thread(void *context);



int rtw_init_cmd_priv(struct cmd_priv *pcmdpriv);

void rtw_init_cmd_priv(struct cmd_priv *pcmdpriv);



enum rtw_drvextra_cmd_id {

	NONE_WK_CID,

drivers/staging/rtl8188eu/os_dep/os_intfs.c

+1 −5
Original line number Diff line number Diff line
@@ -424,11 +424,7 @@ u8 rtw_init_drv_sw(struct adapter *padapter) 


	RT_TRACE(_module_os_intfs_c_, _drv_info_, ("+%s\n", __func__));



	if ((rtw_init_cmd_priv(&padapter->cmdpriv)) == _FAIL) {

		RT_TRACE(_module_os_intfs_c_, _drv_err_, ("\n Can't init cmd_priv\n"));

		ret8 = _FAIL;

		goto exit;

	}

	rtw_init_cmd_priv(&padapter->cmdpriv);



	padapter->cmdpriv.padapter = padapter;