Commit 14ee976b authored by navin patidar's avatar navin patidar Committed by Greg Kroah-Hartman
Browse files

staging: rtl8188eu: Rework function phy_PathA_IQK_8188E() 



Rename CamelCase function name and local variables.
Remove unnecessary debugging messages and local variables.

Signed-off-by: default avatarnavin patidar <navin.patidar@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0fdd0c32

drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c

+11 −26
Original line number Diff line number Diff line
@@ -358,50 +358,35 @@ void rtl88eu_dm_txpower_tracking_callback_thermalmeter(struct adapter *adapt) 


#define MAX_TOLERANCE 5



static u8 /* bit0 = 1 => Tx OK, bit1 = 1 => Rx OK */

phy_PathA_IQK_8188E(struct adapter *adapt, bool configPathB)

static u8 phy_path_a_iqk(struct adapter *adapt, bool config_pathb)

{

	u32 regeac, regE94, regE9C, regEA4;

	u32 reg_eac, reg_e94, reg_e9c, reg_ea4;

	u8 result = 0x00;

	struct hal_data_8188e	*pHalData = GET_HAL_DATA(adapt);

	struct odm_dm_struct *dm_odm = &pHalData->odmpriv;

	ODM_RT_TRACE(dm_odm, ODM_COMP_CALIBRATION, ODM_DBG_LOUD, ("Path A IQK!\n"));



	/* 1 Tx IQK */

	/* path-A IQK setting */

	ODM_RT_TRACE(dm_odm, ODM_COMP_CALIBRATION, ODM_DBG_LOUD, ("Path-A IQK setting!\n"));

	phy_set_bb_reg(adapt, rTx_IQK_Tone_A, bMaskDWord, 0x10008c1c);

	phy_set_bb_reg(adapt, rRx_IQK_Tone_A, bMaskDWord, 0x30008c1c);

	phy_set_bb_reg(adapt, rTx_IQK_PI_A, bMaskDWord, 0x8214032a);

	phy_set_bb_reg(adapt, rRx_IQK_PI_A, bMaskDWord, 0x28160000);



	/* LO calibration setting */

	ODM_RT_TRACE(dm_odm, ODM_COMP_CALIBRATION, ODM_DBG_LOUD, ("LO calibration setting!\n"));

	phy_set_bb_reg(adapt, rIQK_AGC_Rsp, bMaskDWord, 0x00462911);



	/* One shot, path A LOK & IQK */

	ODM_RT_TRACE(dm_odm, ODM_COMP_CALIBRATION, ODM_DBG_LOUD, ("One shot, path A LOK & IQK!\n"));

	phy_set_bb_reg(adapt, rIQK_AGC_Pts, bMaskDWord, 0xf9000000);

	phy_set_bb_reg(adapt, rIQK_AGC_Pts, bMaskDWord, 0xf8000000);



	/*  delay x ms */

	ODM_RT_TRACE(dm_odm, ODM_COMP_CALIBRATION, ODM_DBG_LOUD, ("Delay %d ms for One shot, path A LOK & IQK.\n", IQK_DELAY_TIME_88E));

	/* PlatformStallExecution(IQK_DELAY_TIME_88E*1000); */

	mdelay(IQK_DELAY_TIME_88E);



	/*  Check failed */

	regeac = phy_query_bb_reg(adapt, rRx_Power_After_IQK_A_2, bMaskDWord);

	ODM_RT_TRACE(dm_odm, ODM_COMP_CALIBRATION, ODM_DBG_LOUD, ("0xeac = 0x%x\n", regeac));

	regE94 = phy_query_bb_reg(adapt, rTx_Power_Before_IQK_A, bMaskDWord);

	ODM_RT_TRACE(dm_odm, ODM_COMP_CALIBRATION, ODM_DBG_LOUD, ("0xe94 = 0x%x\n", regE94));

	regE9C = phy_query_bb_reg(adapt, rTx_Power_After_IQK_A, bMaskDWord);

	ODM_RT_TRACE(dm_odm, ODM_COMP_CALIBRATION, ODM_DBG_LOUD,  ("0xe9c = 0x%x\n", regE9C));

	regEA4 = phy_query_bb_reg(adapt, rRx_Power_Before_IQK_A_2, bMaskDWord);

	ODM_RT_TRACE(dm_odm, ODM_COMP_CALIBRATION, ODM_DBG_LOUD, ("0xea4 = 0x%x\n", regEA4));



	if (!(regeac & BIT28) &&

	    (((regE94 & 0x03FF0000)>>16) != 0x142) &&

	    (((regE9C & 0x03FF0000)>>16) != 0x42))

	reg_eac = phy_query_bb_reg(adapt, rRx_Power_After_IQK_A_2, bMaskDWord);

	reg_e94 = phy_query_bb_reg(adapt, rTx_Power_Before_IQK_A, bMaskDWord);

	reg_e9c = phy_query_bb_reg(adapt, rTx_Power_After_IQK_A, bMaskDWord);

	reg_ea4 = phy_query_bb_reg(adapt, rRx_Power_Before_IQK_A_2, bMaskDWord);



	if (!(reg_eac & BIT28) &&

	    (((reg_e94 & 0x03FF0000)>>16) != 0x142) &&

	    (((reg_e9c & 0x03FF0000)>>16) != 0x42))

		result |= 0x01;

	return result;

}
@@ -987,7 +972,7 @@ static void phy_IQCalibrate_8188E(struct adapter *adapt, s32 result[][8], u8 t, 
	phy_set_bb_reg(adapt, rRx_IQK, bMaskDWord, 0x81004800);



	for (i = 0; i < retryCount; i++) {

		PathAOK = phy_PathA_IQK_8188E(adapt, is2t);

		PathAOK = phy_path_a_iqk(adapt, is2t);

		if (PathAOK == 0x01) {

			ODM_RT_TRACE(dm_odm, ODM_COMP_CALIBRATION, ODM_DBG_LOUD, ("Path A Tx IQK Success!!\n"));

				result[t][0] = (phy_query_bb_reg(adapt, rTx_Power_Before_IQK_A, bMaskDWord)&0x3FF0000)>>16;