Commit 14ff8e19 authored by David Sterba's avatar David Sterba
Browse files

btrfs: no need to run delayed refs after commit_fs_roots during commit 



The inode number cache has been removed in this dev cycle, there's one
more leftover. We don't need to run the delayed refs again after
commit_fs_roots as stated in the comment, because btrfs_save_ino_cache
is no more since 5297199a ("btrfs: remove inode number cache
feature").

Nothing else between commit_fs_roots and btrfs_qgroup_account_extents
could create new delayed refs so the qgroup consistency should be safe.

Reviewed-by: default avatarNikolay Borisov <nborisov@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent e076ab2a

fs/btrfs/transaction.c

+0 −8
Original line number Original line Diff line number Diff line
@@ -2264,14 +2264,6 @@ int btrfs_commit_transaction(struct btrfs_trans_handle *trans) 
	 */

	 */

	btrfs_free_log_root_tree(trans, fs_info);

	btrfs_free_log_root_tree(trans, fs_info);





	/*

	 * commit_fs_roots() can call btrfs_save_ino_cache(), which generates

	 * new delayed refs. Must handle them or qgroup can be wrong.

	 */

	ret = btrfs_run_delayed_refs(trans, (unsigned long)-1);

	if (ret)

		goto unlock_tree_log;



	/*

	/*

	 * Since fs roots are all committed, we can get a quite accurate

	 * Since fs roots are all committed, we can get a quite accurate

	 * new_roots. So let's do quota accounting.

	 * new_roots. So let's do quota accounting.