Commit 167c0bd3 authored by Nikolay Borisov's avatar Nikolay Borisov Committed by David Sterba
Browse files

btrfs: get next entry in tree_search_offset before doing checks 



This is a small optimisation since the currently 'entry' is already
checked in the if () {} else if {} construct above the loop. In essence
the first iteration of the final while loop is redundant. To eliminate
this extra check simply get the next entry at the beginning of the loop.

Reviewed-by: default avatarJosef Bacik <josef@toxicpanda.com>
Signed-off-by: default avatarNikolay Borisov <nborisov@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent bbf27275

fs/btrfs/free-space-cache.c

+4 −5
Original line number Diff line number Diff line
@@ -1730,6 +1730,10 @@ tree_search_offset(struct btrfs_free_space_ctl *ctl, 
		return NULL;



	while (1) {

		n = rb_next(&entry->offset_index);

		if (!n)

			return NULL;

		entry = rb_entry(n, struct btrfs_free_space, offset_index);

		if (entry->bitmap) {

			if (entry->offset + BITS_PER_BITMAP *

			    ctl->unit > offset)
@@ -1738,11 +1742,6 @@ tree_search_offset(struct btrfs_free_space_ctl *ctl, 
			if (entry->offset + entry->bytes > offset)

				break;

		}



		n = rb_next(&entry->offset_index);

		if (!n)

			return NULL;

		entry = rb_entry(n, struct btrfs_free_space, offset_index);

	}

	return entry;

}