Commit 16b0b7ad authored by Michal Orzel's avatar Michal Orzel Committed by Andrew Morton
Browse files

kexec: remove redundant assignments 

Get rid of redundant assignments which end up in values not being read
either because they are overwritten or the function ends.

Reported by clang-tidy [deadcode.DeadStores]

Link: https://lkml.kernel.org/r/20220326180948.192154-1-michalorzel.eng@gmail.com


Signed-off-by: default avatarMichal Orzel <michalorzel.eng@gmail.com>
Acked-by: default avatarBaoquan He <bhe@redhat.com>
Cc: Eric Biederman <ebiederm@xmission.com>
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Michal Orzel <michalorzel.eng@gmail.com>

Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent f224cabe

kernel/kexec_core.c

+0 −2
Original line number Diff line number Diff line
@@ -768,7 +768,6 @@ static struct page *kimage_alloc_page(struct kimage *image, 
				kimage_free_pages(old_page);

				continue;

			}

			addr = old_addr;

			page = old_page;

			break;

		}
@@ -788,7 +787,6 @@ static int kimage_load_normal_segment(struct kimage *image, 
	unsigned char __user *buf = NULL;

	unsigned char *kbuf = NULL;



	result = 0;

	if (image->file_mode)

		kbuf = segment->kbuf;

	else