Commit 17e67d4c authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

[media] mb86a20s: change AGC tuning parameters 



Use the AGC settings present on a newer device.
The initial settings were taken from one of the first devices with
mb86a20s, and there are several reports that this is not working
properly on some places.
So, instead of keeping using it, get the parameters taken from a
newer device. Tests are welcomed.
Tested also with cx231xx PixelView SBTVD Hybrid with no regressions
noticed so far.

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 0921ecfd

drivers/media/dvb-core/dmxdev.c

+2 −1
Original line number Diff line number Diff line
@@ -852,7 +852,8 @@ static int dvb_dmxdev_filter_set(struct dmxdev *dmxdev, 
				 struct dmxdev_filter *dmxdevfilter,

				 struct dmx_sct_filter_params *params)

{

	dprintk("function : %s\n", __func__);

	dprintk("function : %s, PID=0x%04x, flags=%02x, timeout=%d\n",

		__func__, params->pid, params->flags, params->timeout);



	dvb_dmxdev_filter_stop(dmxdevfilter);

drivers/media/dvb-frontends/mb86a20s.c

+44 −42
Original line number Diff line number Diff line
@@ -55,7 +55,7 @@ static struct regdata mb86a20s_init1[] = { 
	{ 0x70, 0xff },

	{ 0x08, 0x01 },

	{ 0x09, 0x3e },

	{ 0x50, 0xd1 }, { 0x51, 0x22 },

	{ 0x50, 0xd1 }, { 0x51, 0x20 },

	{ 0x39, 0x01 },

	{ 0x71, 0x00 },

	{ 0x28, 0x2a }, { 0x29, 0x00 }, { 0x2a, 0xff }, { 0x2b, 0x80 },
@@ -64,23 +64,23 @@ static struct regdata mb86a20s_init1[] = { 
static struct regdata mb86a20s_init2[] = {

	{ 0x28, 0x22 }, { 0x29, 0x00 }, { 0x2a, 0x1f }, { 0x2b, 0xf0 },

	{ 0x3b, 0x21 },

	{ 0x3c, 0x3a },

	{ 0x3c, 0x38 },

	{ 0x01, 0x0d },

	{ 0x04, 0x08 }, { 0x05, 0x05 },

	{ 0x04, 0x08 }, { 0x05, 0x03 },

	{ 0x04, 0x0e }, { 0x05, 0x00 },

	{ 0x04, 0x0f }, { 0x05, 0x14 },

	{ 0x04, 0x0b }, { 0x05, 0x8c },

	{ 0x04, 0x0f }, { 0x05, 0x37 },

	{ 0x04, 0x0b }, { 0x05, 0x78 },

	{ 0x04, 0x00 }, { 0x05, 0x00 },

	{ 0x04, 0x01 }, { 0x05, 0x07 },

	{ 0x04, 0x02 }, { 0x05, 0x0f },

	{ 0x04, 0x03 }, { 0x05, 0xa0 },

	{ 0x04, 0x01 }, { 0x05, 0x1e },

	{ 0x04, 0x02 }, { 0x05, 0x07 },

	{ 0x04, 0x03 }, { 0x05, 0xd0 },

	{ 0x04, 0x09 }, { 0x05, 0x00 },

	{ 0x04, 0x0a }, { 0x05, 0xff },

	{ 0x04, 0x27 }, { 0x05, 0x64 },

	{ 0x04, 0x27 }, { 0x05, 0x00 },

	{ 0x04, 0x28 }, { 0x05, 0x00 },

	{ 0x04, 0x1e }, { 0x05, 0xff },

	{ 0x04, 0x29 }, { 0x05, 0x0a },

	{ 0x04, 0x32 }, { 0x05, 0x0a },

	{ 0x04, 0x1e }, { 0x05, 0x00 },

	{ 0x04, 0x29 }, { 0x05, 0x64 },

	{ 0x04, 0x32 }, { 0x05, 0x02 },

	{ 0x04, 0x14 }, { 0x05, 0x02 },

	{ 0x04, 0x04 }, { 0x05, 0x00 },

	{ 0x04, 0x05 }, { 0x05, 0x22 },
@@ -147,39 +147,39 @@ static struct regdata mb86a20s_init2[] = { 
	{ 0x50, 0xd5 }, { 0x51, 0x01 },		/* Serial */

	{ 0x50, 0xd6 }, { 0x51, 0x1f },

	{ 0x50, 0xd2 }, { 0x51, 0x03 },

	{ 0x50, 0xd7 }, { 0x51, 0x3f },

	{ 0x28, 0x74 }, { 0x29, 0x00 }, { 0x28, 0x74 }, { 0x29, 0x40 },

	{ 0x28, 0x46 }, { 0x29, 0x2c }, { 0x28, 0x46 }, { 0x29, 0x0c },

	{ 0x50, 0xd7 }, { 0x51, 0xbf },

	{ 0x28, 0x74 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0xff },

	{ 0x28, 0x46 }, { 0x29, 0x00 }, { 0x2a, 0x1a }, { 0x2b, 0x0c },



	{ 0x04, 0x40 }, { 0x05, 0x00 },

	{ 0x28, 0x00 }, { 0x29, 0x10 },

	{ 0x28, 0x05 }, { 0x29, 0x02 },

	{ 0x28, 0x00 }, { 0x2b, 0x08 },

	{ 0x28, 0x05 }, { 0x2b, 0x00 },

	{ 0x1c, 0x01 },

	{ 0x28, 0x06 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x03 },

	{ 0x28, 0x07 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x0d },

	{ 0x28, 0x08 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x02 },

	{ 0x28, 0x09 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x01 },

	{ 0x28, 0x0a }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x21 },

	{ 0x28, 0x0b }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x29 },

	{ 0x28, 0x0c }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x16 },

	{ 0x28, 0x0d }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x31 },

	{ 0x28, 0x0e }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x0e },

	{ 0x28, 0x0f }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x4e },

	{ 0x28, 0x10 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x46 },

	{ 0x28, 0x11 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x0f },

	{ 0x28, 0x12 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x56 },

	{ 0x28, 0x13 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x35 },

	{ 0x28, 0x14 }, { 0x29, 0x00 }, { 0x2a, 0x01 }, { 0x2b, 0xbe },

	{ 0x28, 0x15 }, { 0x29, 0x00 }, { 0x2a, 0x01 }, { 0x2b, 0x84 },

	{ 0x28, 0x16 }, { 0x29, 0x00 }, { 0x2a, 0x03 }, { 0x2b, 0xee },

	{ 0x28, 0x17 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x98 },

	{ 0x28, 0x18 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x9f },

	{ 0x28, 0x19 }, { 0x29, 0x00 }, { 0x2a, 0x07 }, { 0x2b, 0xb2 },

	{ 0x28, 0x1a }, { 0x29, 0x00 }, { 0x2a, 0x06 }, { 0x2b, 0xc2 },

	{ 0x28, 0x1b }, { 0x29, 0x00 }, { 0x2a, 0x07 }, { 0x2b, 0x4a },

	{ 0x28, 0x1c }, { 0x29, 0x00 }, { 0x2a, 0x01 }, { 0x2b, 0xbc },

	{ 0x28, 0x1d }, { 0x29, 0x00 }, { 0x2a, 0x04 }, { 0x2b, 0xba },

	{ 0x28, 0x1e }, { 0x29, 0x00 }, { 0x2a, 0x06 }, { 0x2b, 0x14 },

	{ 0x28, 0x06 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x1f },

	{ 0x28, 0x07 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x18 },

	{ 0x28, 0x08 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x12 },

	{ 0x28, 0x09 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x30 },

	{ 0x28, 0x0a }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x37 },

	{ 0x28, 0x0b }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x02 },

	{ 0x28, 0x0c }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x09 },

	{ 0x28, 0x0d }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x06 },

	{ 0x28, 0x0e }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x7b },

	{ 0x28, 0x0f }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x76 },

	{ 0x28, 0x10 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x7d },

	{ 0x28, 0x11 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x08 },

	{ 0x28, 0x12 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x0b },

	{ 0x28, 0x13 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x00 },

	{ 0x28, 0x14 }, { 0x29, 0x00 }, { 0x2a, 0x01 }, { 0x2b, 0xf2 },

	{ 0x28, 0x15 }, { 0x29, 0x00 }, { 0x2a, 0x01 }, { 0x2b, 0xf3 },

	{ 0x28, 0x16 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x05 },

	{ 0x28, 0x17 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x16 },

	{ 0x28, 0x18 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x0f },

	{ 0x28, 0x19 }, { 0x29, 0x00 }, { 0x2a, 0x07 }, { 0x2b, 0xef },

	{ 0x28, 0x1a }, { 0x29, 0x00 }, { 0x2a, 0x07 }, { 0x2b, 0xd8 },

	{ 0x28, 0x1b }, { 0x29, 0x00 }, { 0x2a, 0x07 }, { 0x2b, 0xf1 },

	{ 0x28, 0x1c }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x3d },

	{ 0x28, 0x1d }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x94 },

	{ 0x28, 0x1e }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0xba },

	{ 0x50, 0x1e }, { 0x51, 0x5d },

	{ 0x50, 0x22 }, { 0x51, 0x00 },

	{ 0x50, 0x23 }, { 0x51, 0xc8 },
@@ -188,6 +188,8 @@ static struct regdata mb86a20s_init2[] = { 
	{ 0x50, 0x26 }, { 0x51, 0x00 },

	{ 0x50, 0x27 }, { 0x51, 0xc3 },

	{ 0x50, 0x39 }, { 0x51, 0x02 },

	{ 0xec, 0x0f },

	{ 0xeb, 0x1f },

	{ 0x28, 0x6a }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x00 },

	{ 0xd0, 0x00 },

};