Commit 17f0d1b9 authored by Jiapeng Zhong's avatar Jiapeng Zhong Committed by Wim Van Sebroeck
Browse files

watchdog: hpwdt: Assign boolean values to a bool variable 



Fix the following coccicheck warnings:

 ./drivers/watchdog/hpwdt.c:345:2-12: WARNING: Assignment of
0/1 to bool variable.

./drivers/watchdog/hpwdt.c:126:2-12: WARNING: Assignment of
0/1 to bool variable.

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Signed-off-by: default avatarJiapeng Zhong <abaci-bugfix@linux.alibaba.com>
Reviewed-by: default avatarJerry Hoemann <jerry.hoemann@hpe.com>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/1611128890-79204-1-git-send-email-abaci-bugfix@linux.alibaba.com


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarWim Van Sebroeck <wim@linux-watchdog.org>
parent fa0f8d51

drivers/watchdog/hpwdt.c

+3 −3
Original line number Diff line number Diff line
@@ -123,7 +123,7 @@ static int hpwdt_settimeout(struct watchdog_device *wdd, unsigned int val) 
	if (val <= wdd->pretimeout) {

		dev_dbg(wdd->parent, "pretimeout < timeout. Setting to zero\n");

		wdd->pretimeout = 0;

		pretimeout = 0;

		pretimeout = false;

		if (watchdog_active(wdd))

			hpwdt_start(wdd);

	}
@@ -336,13 +336,13 @@ static int hpwdt_init_one(struct pci_dev *dev, 
	watchdog_init_timeout(&hpwdt_dev, soft_margin, NULL);



	if (is_kdump_kernel()) {

		pretimeout = 0;

		pretimeout = false;

		kdumptimeout = 0;

	}



	if (pretimeout && hpwdt_dev.timeout <= PRETIMEOUT_SEC) {

		dev_warn(&dev->dev, "timeout <= pretimeout. Setting pretimeout to zero\n");

		pretimeout = 0;

		pretimeout = false;

	}

	hpwdt_dev.pretimeout = pretimeout ? PRETIMEOUT_SEC : 0;

	kdumptimeout = min(kdumptimeout, HPWDT_MAX_TIMER);