Commit 186ab099 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Greg Kroah-Hartman
Browse files

serial: core: Drop duplicate NULL check in uart_*shutdown() 



The free_page(addr), which becomes free_pages(addr, 0) checks addr
against 0. No need to repeat this check in the callers.

Acked-by: default avatarJiri Slaby <jirislaby@kernel.org>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20220204152808.10808-1-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3c5b2f5b

drivers/tty/serial/serial_core.c

+2 −4
Original line number Diff line number Diff line
@@ -317,7 +317,6 @@ static void uart_shutdown(struct tty_struct *tty, struct uart_state *state) 
	state->xmit.buf = NULL;

	uart_port_unlock(uport, flags);



	if (xmit_buf)

	free_page((unsigned long)xmit_buf);

}
@@ -1569,7 +1568,6 @@ static void uart_tty_port_shutdown(struct tty_port *port) 
	state->xmit.buf = NULL;

	spin_unlock_irq(&uport->lock);



	if (buf)

	free_page((unsigned long)buf);



	uart_change_pm(state, UART_PM_STATE_OFF);