Commit 1ad2c135 authored by Hans de Goede's avatar Hans de Goede Committed by Mauro Carvalho Chehab
Browse files

media: atomisp: Remove atomisp_ospm_dphy_down() call from probe error path 



The only thing which atomisp_ospm_dphy_down() does is disable the CSI
pins, but if we failed to probe the ISP then these will never have
been enabled (because the ISP never started streaming).

So the atomisp_ospm_dphy_down() call in the probe error path is
unnecessary, remove it.

Reviewed-by: default avatarAndy Shevchenko <andy@kernel.org>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 5317baa0

drivers/staging/media/atomisp/pci/atomisp_v4l2.c

+0 −2
Original line number Diff line number Diff line
@@ -1673,8 +1673,6 @@ static int atomisp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i 


	atomisp_msi_irq_uninit(isp);



	atomisp_ospm_dphy_down(isp);



	/* Address later when we worry about the ...field chips */

	if (IS_ENABLED(CONFIG_PM) && atomisp_mrfld_power(isp, false))

		dev_err(&pdev->dev, "Failed to switch off ISP\n");