Commit 1ae65e27 authored by Wei Yang's avatar Wei Yang Committed by Andrew Morton
Browse files

mm/vmscan: filter empty page_list at the beginning 

node_page_list would always be !empty on finishing the loop, except
page_list is empty.

Let's handle empty page_list before doing any real work including touching
PF_MEMALLOC flag.

Link: https://lkml.kernel.org/r/20220429014426.29223-1-richard.weiyang@gmail.com


Signed-off-by: default avatarWei Yang <richard.weiyang@gmail.com>
Reviewed-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Cc: Minchan Kim <minchan@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent f19a27e3

mm/vmscan.c

+6 −4
Original line number Diff line number Diff line
@@ -2568,9 +2568,12 @@ unsigned long reclaim_pages(struct list_head *page_list) 
	struct page *page;

	unsigned int noreclaim_flag;



	if (list_empty(page_list))

		return nr_reclaimed;



	noreclaim_flag = memalloc_noreclaim_save();



	while (!list_empty(page_list)) {

	do {

		page = lru_to_page(page_list);

		if (nid == NUMA_NO_NODE)

			nid = page_to_nid(page);
@@ -2583,9 +2586,8 @@ unsigned long reclaim_pages(struct list_head *page_list) 


		nr_reclaimed += reclaim_page_list(&node_page_list, NODE_DATA(nid));

		nid = NUMA_NO_NODE;

	}

	} while (!list_empty(page_list));



	if (!list_empty(&node_page_list))

	nr_reclaimed += reclaim_page_list(&node_page_list, NODE_DATA(nid));



	memalloc_noreclaim_restore(noreclaim_flag);