Commit 1b550a0b authored by Johannes Berg's avatar Johannes Berg
Browse files

nl80211: don't hold RTNL in color change request 

It's not necessary to hold the RTNL across color change
requests, since all the inner locking needs only the
wiphy mutex which we already hold as well.

Fixes: 0d2ab3ae ("nl80211: add support for BSS coloring")
Link: https://lore.kernel.org/r/20220414140402.32e03e8c261b.I5e7dc6bc563a129b938c43298da6bb4e812400a5@changeid


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 34c9a0e7

net/wireless/nl80211.c

+1 −2
Original line number Diff line number Diff line
@@ -16273,8 +16273,7 @@ static const struct genl_small_ops nl80211_small_ops[] = { 
		.validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,

		.doit = nl80211_color_change,

		.flags = GENL_UNS_ADMIN_PERM,

		.internal_flags = NL80211_FLAG_NEED_NETDEV_UP |

				  NL80211_FLAG_NEED_RTNL,

		.internal_flags = NL80211_FLAG_NEED_NETDEV_UP,

	},

	{

		.cmd = NL80211_CMD_SET_FILS_AAD,