Commit 1bcafc04 authored by Matthias Kaehlcke's avatar Matthias Kaehlcke Committed by Greg Kroah-Hartman
Browse files

usb: misc: onboard_usb_hub: Drop reset delay in onboard_hub_power_off() 



onboard_hub_power_off() currently has a delay after asserting the
reset of the hub. There is already a delay in onboard_hub_power_on()
before de-asserting the reset, which ensures that the reset is
asserted for the required time, so the delay in _power_off() is not
needed.

Skip the reset GPIO check before calling gpiod_set_value_cansleep(),
the function returns early when the GPIO descriptor is NULL.

Reviewed-By: default avatarAlexander Stein <alexander.stein@ew.tq-group.com>
Reviewed-by: default avatarDouglas Anderson <dianders@chromium.org>
Signed-off-by: default avatarMatthias Kaehlcke <mka@chromium.org>
Link: https://lore.kernel.org/r/20220805111836.1.Id5a4dc0a2c046236116693aa55672295513a0f2a@changeid


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 040f2dbd

drivers/usb/misc/onboard_usb_hub.c

+1 −4
Original line number Diff line number Diff line
@@ -71,10 +71,7 @@ static int onboard_hub_power_off(struct onboard_hub *hub) 
{

	int err;



	if (hub->reset_gpio) {

	gpiod_set_value_cansleep(hub->reset_gpio, 1);

		fsleep(hub->pdata->reset_us);

	}



	err = regulator_disable(hub->vdd);

	if (err) {