Commit 1d87be82 authored by Bart Van Assche's avatar Bart Van Assche Committed by Jens Axboe
Browse files

block: bfq: Fix kernel-doc headers 



Fix the following warnings:

block/bfq-cgroup.c:721: warning: Function parameter or member 'bfqg' not described in '__bfq_bic_change_cgroup'
block/bfq-cgroup.c:721: warning: Excess function parameter 'blkcg' description in '__bfq_bic_change_cgroup'
block/bfq-cgroup.c:870: warning: Function parameter or member 'ioprio_class' not described in 'bfq_reparent_leaf_entity'
block/bfq-cgroup.c:900: warning: Function parameter or member 'ioprio_class' not described in 'bfq_reparent_active_queues'

Cc: Jan Kara <jack@suse.cz>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
Link: https://lore.kernel.org/r/20220617210859.106623-1-bvanassche@acm.org
parent c28c49b0

block/bfq-cgroup.c

+4 −2
Original line number Diff line number Diff line
@@ -706,10 +706,10 @@ void bfq_bfqq_move(struct bfq_data *bfqd, struct bfq_queue *bfqq, 
}



/**

 * __bfq_bic_change_cgroup - move @bic to @cgroup.

 * __bfq_bic_change_cgroup - move @bic to @bfqg.

 * @bfqd: the queue descriptor.

 * @bic: the bic to move.

 * @blkcg: the blk-cgroup to move to.

 * @bfqg: the group to move to.

 *

 * Move bic to blkcg, assuming that bfqd->lock is held; which makes

 * sure that the reference to cgroup is valid across the call (see
@@ -863,6 +863,7 @@ static void bfq_flush_idle_tree(struct bfq_service_tree *st) 
 * @bfqd: the device data structure with the root group.

 * @entity: the entity to move, if entity is a leaf; or the parent entity

 *	    of an active leaf entity to move, if entity is not a leaf.

 * @ioprio_class: I/O priority class to reparent.

 */

static void bfq_reparent_leaf_entity(struct bfq_data *bfqd,

				     struct bfq_entity *entity,
@@ -892,6 +893,7 @@ static void bfq_reparent_leaf_entity(struct bfq_data *bfqd, 
 * @bfqd: the device data structure with the root group.

 * @bfqg: the group to move from.

 * @st: the service tree to start the search from.

 * @ioprio_class: I/O priority class to reparent.

 */

static void bfq_reparent_active_queues(struct bfq_data *bfqd,

				       struct bfq_group *bfqg,

block/bfq-wf2q.c

+2 −0
Original line number Diff line number Diff line
@@ -1360,6 +1360,8 @@ static struct bfq_entity *bfq_first_active_entity(struct bfq_service_tree *st, 
/**

 * __bfq_lookup_next_entity - return the first eligible entity in @st.

 * @st: the service tree.

 * @in_service: whether or not there is an in-service entity for the sched_data

 *	this active tree belongs to.

 *

 * If there is no in-service entity for the sched_data st belongs to,

 * then return the entity that will be set in service if: