Commit 1dbcdf74 authored by Adrien Thierry's avatar Adrien Thierry Committed by Greg Kroah-Hartman
Browse files

staging: vchiq_arm: remove global 'vchiq_states' array 



Remove global 'vchiq_states' array, which is not used anymore.

This is part of an effort to address TODO item "Get rid of all non
essential global structures and create a proper per device structure"

Tested-by: default avatarStefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: default avatarAdrien Thierry <athierry@redhat.com>
Link: https://lore.kernel.org/r/20220518191126.60396-10-athierry@redhat.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ed57d93e

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c

+0 −8
Original line number Diff line number Diff line
@@ -162,7 +162,6 @@ int vchiq_sync_log_level = VCHIQ_LOG_DEFAULT; 
DEFINE_SPINLOCK(bulk_waiter_spinlock);

static DEFINE_SPINLOCK(quota_spinlock);



struct vchiq_state *vchiq_states[VCHIQ_MAX_STATES];

static unsigned int handle_seq;



static const char *const srvstate_names[] = {
@@ -2157,11 +2156,6 @@ vchiq_init_state(struct vchiq_state *state, struct vchiq_slot_zero *slot_zero, s 
	char threadname[16];

	int i, ret;



	if (vchiq_states[0]) {

		pr_err("%s: VCHIQ state already initialized\n", __func__);

		return -EINVAL;

	}



	local = &slot_zero->slave;

	remote = &slot_zero->master;
@@ -2282,8 +2276,6 @@ vchiq_init_state(struct vchiq_state *state, struct vchiq_slot_zero *slot_zero, s 
	wake_up_process(state->recycle_thread);

	wake_up_process(state->sync_thread);



	vchiq_states[0] = state;



	/* Indicate readiness to the other side */

	local->initialised = 1;

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h

+0 −2
Original line number Diff line number Diff line
@@ -449,8 +449,6 @@ extern int vchiq_core_log_level; 
extern int vchiq_core_msg_log_level;

extern int vchiq_sync_log_level;



extern struct vchiq_state *vchiq_states[VCHIQ_MAX_STATES];



extern const char *

get_conn_state_name(enum vchiq_connstate conn_state);