Commit 1e80d9cb authored by Dan Carpenter's avatar Dan Carpenter Committed by Jessica Yu
Browse files

module: potential uninitialized return in module_kallsyms_on_each_symbol() 



Smatch complains that:

	kernel/module.c:4472 module_kallsyms_on_each_symbol()
        error: uninitialized symbol 'ret'.

This warning looks like it could be correct if the &modules list is
empty.

Fixes: 013c1667 ("kallsyms: refactor {,module_}kallsyms_on_each_symbol")
Reviewed-by: default avatarMiroslav Benes <mbenes@suse.cz>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarJessica Yu <jeyu@kernel.org>
parent 36794822

kernel/module.c

+1 −1
Original line number Diff line number Diff line
@@ -4388,7 +4388,7 @@ int module_kallsyms_on_each_symbol(int (*fn)(void *, const char *, 
{

	struct module *mod;

	unsigned int i;

	int ret;

	int ret = 0;



	mutex_lock(&module_mutex);

	list_for_each_entry(mod, &modules, list) {