Commit 1f295373 authored Jul 29, 2021 by Filipe Manana Committed by David Sterba Aug 23, 2021

btrfs: update comment at log_conflicting_inodes()



A comment at log_conflicting_inodes() mentions that we check the inode's
logged_trans field instead of using btrfs_inode_in_log() because the field
last_log_commit is not updated when we log that an inode exists and the
inode has the full sync flag (BTRFS_INODE_NEEDS_FULL_SYNC) set. The part
about the full sync flag is not true anymore since commit 9acc8103
("btrfs: fix unpersisted i_size on fsync after expanding truncate"), so
update the comment to not mention that part anymore.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent d135a533

fs/btrfs/tree-log.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -5092,8 +5092,8 @@ static int log_conflicting_inodes(struct btrfs_trans_handle *trans,
		/*
		* Check the inode's logged_trans only instead of
		* btrfs_inode_in_log(). This is because the last_log_commit of
		* the inode is not updated when we only log that it exists and
		* it has the full sync bit set (see btrfs_log_inode()).
		* the inode is not updated when we only log that it exists (see
		* btrfs_log_inode()).
		*/
		if (BTRFS_I(inode)->logged_trans == trans->transid) {
		spin_unlock(&BTRFS_I(inode)->lock);