Commit 1fd452c4 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Sam Ravnborg
Browse files

drm/panel-novatek-nt35510: Emit an error message if power off fails 



Returning an error code from a mipi_dsi remove callback fails, this is
silently ignored. (mipi_dsi_drv_remove() propagates the return value to
device_remove() which ignores it.) So emit an error code in the driver
remove function and return 0.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarSam Ravnborg <sam@ravnborg.org>
Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220708094922.1408248-3-u.kleine-koenig@pengutronix.de
parent d72ac4bb

drivers/gpu/drm/panel/panel-novatek-nt35510.c

+4 −1
Original line number Diff line number Diff line
@@ -974,9 +974,12 @@ static int nt35510_remove(struct mipi_dsi_device *dsi) 
	mipi_dsi_detach(dsi);

	/* Power off */

	ret = nt35510_power_off(nt);

	if (ret)

		dev_err(&dsi->dev, "Failed to power off\n");



	drm_panel_remove(&nt->panel);



	return ret;

	return 0;

}



/*